Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 2 years ago

Closed 21 months ago

Last modified 20 months ago

#10613 closed Bug Report - General (fixed)

MythVideo file parser no longer recognises the top level directory

Reported by: jlbergqvist@… Owned by: knight
Priority: minor Milestone: 0.26
Component: MythTV - Video Library Version: 0.25-fixes
Severity: medium Keywords:
Cc: Ticket locked: yes

Description

Before 0.25, the video browser would fill in basic metadata (show title, subtitle, episode & season number) from the filename and directory path. Now, it doesn't recognise the directory above the one the video is in when filling in metadata, which is a pain if you have a TV show with seasons in seperate folders. Previously it would recognise this heirarchy fine:

Frasier -> Season 01 -> 1x01 - The Good Son.ext and would grab the show title (Frasier) the Episode Name and Number from the file name.

as of 0.25, the parser (using this example) ignores everything before the "Season 01" Directory. So instead of the show title being "Frasier", the title is "Season 01", which means when you run a metadata scan, it doesn't pick up any info as it uses "Season 01" as the search term.

Could this behaviour be put back? I don't see why this has changed, and its only a minor issue.

Attachments (0)

Change History (16)

comment:1 Changed 2 years ago by wagnerrp

  • Component changed from MythTV - General to MythTV - Video Library
  • Milestone changed from 0.25.1 to unknown
  • Owner set to wagnerrp
  • Status changed from new to accepted

I'll look through this, but none of that code has changed since before the 0.24 release, and the behavior should be exactly the same as before.

comment:2 Changed 2 years ago by wagnerrp

  • Status changed from accepted to infoneeded

The only potential cause we can think of is a change in the regular expression behavior in Qt. What version of Qt do you currently have installed?

comment:3 Changed 2 years ago by jlbergqvist@…

My version is: 4:4.7.4-0ubuntu8.1 and i'm using ubuntu 11.10 64-bit.

comment:4 Changed 2 years ago by jlbergqvist@…

Any updates? :)

comment:5 Changed 2 years ago by stuartm

  • Ticket locked set

comment:6 Changed 2 years ago by wagnerrp

  • Resolution set to Invalid
  • Status changed from infoneeded to closed
  • Ticket locked unset

The scanner uses the localized versions of the terms "Season" and "Episode", rather than those terms themselves. That means for example, if one is using the en-GB translation, the scanner is looking for "Series", and the use of "Season" would be misinterpreted. The code is working exactly as designed, if perhaps not completely as expected. I'm closing this ticket for now, but unlocking it in the event someone wants to come up with a patch to make the regular expression handle all forms of that term that are available in the translation files simultaneously.

comment:7 Changed 2 years ago by knight

  • Owner changed from wagnerrp to knight

comment:8 Changed 2 years ago by knight

  • Resolution Invalid deleted
  • Status changed from closed to new

comment:9 Changed 2 years ago by knight

  • Status changed from new to assigned

comment:10 Changed 2 years ago by Nicolas Riendeau <nriendeau@…>

In 77d0afc9b155161c402abc328edae86b0c97a797/mythtv:

Make the video file parser handle both "Series" and "Season" as
equivalent for the English GB translation.

This is the 0.25-fixes version of that fix which attempt to address
this problem while avoiding to break the "Season" matching for the
other translations. The development version will have a more complete
(but more intrusive) fix.

Refs #10613

PS: This is done with the blessing of the English GB translator.

comment:11 follow-up: Changed 21 months ago by Nicolas Riendeau <nriendeau@…>

In de9ede4a8eeaa335584ab466f29f928db51238ba/mythtv:

Add the new strings we will use for video metadata parsing

Refs #10613

comment:12 in reply to: ↑ 11 Changed 21 months ago by mikey_31415@…

Replying to Nicolas Riendeau <nriendeau@…>:

In de9ede4a8eeaa335584ab466f29f928db51238ba/mythtv:

Add the new strings we will use for video metadata parsing

Refs #10613

The last thing that I want to do is scroll through literally thousands of video files alphabetically listed by leaf fill names when I’m trying to find something to watch on my DLNA client devices. Directory hierarchy helps by creating structure to break large video collections into something that is actually usable. Quibbling over “Season” or “Series” isn’t going to fix this!!!

Prediction: Myth will become USELESS to anyone with a sizable collection without directory hierarchy video file names.

Refs #10613
}}}

comment:13 Changed 21 months ago by mikey_31415@…

I too have been bothered by the 0.25 release that does not contain the full file path name in the DNLA published video names. Only the leaf file name is visible. Rather than arbitrate which strings are going to be accepted as part of the path name, I propose that the entire path name (without translation or interpretation) be published. This would return the usable behavior and features that were contained in the pre-0.25 releases that most people desire from their MythBackend?.

The last thing that I want to do is scroll through literally thousands of video files alphabetically listed by leaf fill names when I’m trying to find something to watch on my DLNA client devices. Directory hierarchy helps by creating structure to break large video collections into something that is actually usable. Quibbling over “Season” or “Series” isn’t going to fix this!!!

Prediction: Myth will become USELESS to anyone with a sizable collection without directory hierarchy video file names.

comment:14 Changed 21 months ago by beirdo

  • Ticket locked set

mikey: your comments are off-topic, and discussion should be on the mailing lists. Please open a new ticket for new issues.

comment:15 Changed 21 months ago by Nicolas Riendeau <nriendeau@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 0f3d088bc185605fb14954b9db9b04506e46ab90/mythtv:

Always recognize Season and Episode in addition to their translation
when parsing video files.

Closes #10613

comment:16 Changed 20 months ago by wagnerrp

  • Milestone changed from unknown to 0.26

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.