Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 2 years ago

Closed 23 months ago

Last modified 23 months ago

#10721 closed Patch - Bug Fix (fixed)

Mythmusic FLAC import fails with large number of files

Reported by: mayfields@… Owned by: Stuart Morgan <smorgan@…>
Priority: minor Milestone: 0.25.1
Component: MythTV - General Version: 0.25-fixes
Severity: medium Keywords: mythmusic flac metadata
Cc: Ticket locked: no

Description

When scanning for new music (eg when first installing), mythfrontend crashes when importing metadata for a large number of files. Error indicates too many open files. Incorrect data is also populated as metadata cannot be read for a number of files prior to crash.

In metaioflacvorbis.cpp, flacfile is not deleted after use in MetaIOFLACVorbis::read as it is in the other functions that open the file. This results in each file remaining opened after metadata is read.

Patch attached, tested against 0.25-fixes.

Attachments (1)

scanfornewmusiccrash.patch (409 bytes) - added by anonymous 2 years ago.

Download all attachments as: .zip

Change History (9)

Changed 2 years ago by anonymous

comment:1 Changed 23 months ago by Steven Adeff <adeffs.mythtv@…>

this patch does not work for me, I still get the "Could not open file" error

comment:2 Changed 23 months ago by Stuart Morgan <smorgan@…>

  • Owner set to Stuart Morgan <smorgan@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 7d4b2858a59e4a24f6939a4a7ee26faf997da65e/mythtv:

Fix memory leak when reading flac vorbis tags. Fixes #10721

comment:3 Changed 23 months ago by Stuart Morgan <smorgan@…>

In 18606c9ec38c1cf100113c9ed3b09f9234766ba5/mythtv:

Fix memory leak when reading flac vorbis tags. Fixes #10721
(cherry picked from commit 7d4b2858a59e4a24f6939a4a7ee26faf997da65e)

comment:4 Changed 23 months ago by stuartm

  • Milestone changed from unknown to 0.25.1

comment:5 Changed 23 months ago by Steven Adeff <adeffs.mythtv@…>

I just updated to 0.25.0+fixes.20120525.eb1d4a7 and this does not fix the issue for me.

comment:6 Changed 23 months ago by stuartm

Steven you appear to have a different issue as the original reporter indicated their issue was fixed by the patch. Can you open a new ticket, with a description of the symptoms and a log?

comment:7 Changed 23 months ago by Stuart Morgan <smorgan@…>

In f46b168a87a609b4cc6834f32d392ebf83dfe89e/mythtv:

Fix file handle leaks in oggvorbis and wavpack tag readers. These, along with one in the flac tag reader were caused when we stopped using an instance of the Taglib::FileRef? class to read the track length. Taglib::FileRef? would take ownership of the pointer and delete it when we were done, now that we're not using Taglib::FileRef? we're again responsible for deleting the object which in turn closes the open file handle. Refs #10721

comment:8 Changed 23 months ago by Stuart Morgan <smorgan@…>

In 6ce0af8ce480b7445ebbd198a008f6023d17d24e/mythtv:

Fix file handle leaks in oggvorbis and wavpack tag readers. These, along with one in the flac tag reader were caused when we stopped using an instance of the Taglib::FileRef? class to read the track length. Taglib::FileRef? would take ownership of the pointer and delete it when we were done, now that we're not using Taglib::FileRef? we're again responsible for deleting the object which in turn closes the open file handle. Refs #10721
(cherry picked from commit f46b168a87a609b4cc6834f32d392ebf83dfe89e)

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.