Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 2 years ago

Closed 2 years ago

Last modified 23 months ago

#10746 closed Bug Report - General (fixed)

Typo in programinfo.cpp affecting themes

Reported by: mayfields@… Owned by: David Engel <dengel@…>
Priority: trivial Milestone: 0.25.1
Component: MythTV - General Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

There is a typo in programinfo.cpp where recordinggroup is mis-spelled. The particular spelling (recordingggroup) only occurs once in the code base. This means themes have no data populated when including this field. A workaround is to alter theme but this is not ideal as most themes include this field spelled as recordinggroup.

Present in master as well as 0.25-fixes.

Patch as follows:

--- a/libs/libmyth/programinfo.cpp	2012-04-24 17:35:58.000000000 +0930
+++ b/libs/libmyth/programinfo.cpp	2012-05-23 09:28:28.282810582 +0930
@@ -1515,7 +1515,7 @@
 
     progMap["recpriority"] = recpriority;
     progMap["recpriority2"] = recpriority2;
-    progMap["recordingggroup"] = (recgroup == "Default")
+    progMap["recordinggroup"] = (recgroup == "Default")
                                             ? QObject::tr("Default") : recgroup;
     progMap["playgroup"] = playgroup;
 

Attachments (0)

Change History (3)

comment:1 Changed 2 years ago by David Engel <dengel@…>

  • Owner set to David Engel <dengel@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 2afb07d70f668e2b581c49902a5e69554a7da6b3/mythtv:

Fix typo in ProgramInfo::ToMap?()

Thanks to mayfields for spotting it.

Fixes #10746 .

comment:2 Changed 2 years ago by David Engel <dengel@…>

In 697041382ffb1a876f9b35c2568cfb2143ff263c/mythtv:

Fix typo in ProgramInfo::ToMap?()

Thanks to mayfields for spotting it.

Fixes #10746 .
(cherry picked from commit 2afb07d70f668e2b581c49902a5e69554a7da6b3)

comment:3 Changed 23 months ago by wagnerrp

  • Milestone changed from unknown to 0.25.1

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.