Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 23 months ago

Closed 16 months ago

#10784 closed Patch - Feature (fixed)

match EIT to channels without looking at ONID or TSID in dtv_multiplex

Reported by: dekarl@… Owned by: stuarta
Priority: minor Milestone: 0.27
Component: MythTV - EIT Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This patch allows the EITScanner to find the right channel even if

  • the broadcaster messed up their feed (e.g. feeding DVB-C from DVB-S with mashed up multiplexes. The PMT/SDT gets properly rewritten with new ONID/TSID but the EIT is copied unchanged)
  • the channel scanner couldn't figure out ONID/TSID

Use cases to test

  • passive scan within a transport (worked very well)
  • active scan within a transport (I need to look at it again)
  • any scan across transports (I can't test it due to no access to DVB-S)

Use cases that do not work due to missing glue code

  • EIT from IPTV, etc.

Attachments (2)

0007-Handle-EIT-events-of-the-active-transport-without-lo.patch (10.4 KB) - added by dekarl@… 23 months ago.
first version of the patch
0007-Handle-EIT-events-of-the-active-transport-without-lo.patch-v2 (11.4 KB) - added by dekarl@… 23 months ago.
v2: actually accept any SDT when ONID/TSID are 0

Download all attachments as: .zip

Change History (8)

Changed 23 months ago by dekarl@…

first version of the patch

Changed 23 months ago by dekarl@…

v2: actually accept any SDT when ONID/TSID are 0

comment:1 Changed 23 months ago by dekarl@…

v2 of the patch actually works with NULL as ONID/TSID in dtv_multiplex

comment:2 Changed 21 months ago by dekarl@…

I've been running with the patch in production and it worked so well, in active scan, I forgot to put the ONID/TSID back in.

Still to test DVB with EIT(other) (common on DVB-S) but that just uses the old code path which worked before.

comment:3 Changed 20 months ago by wagnerrp

  • Type changed from Bug Report - General to Patch - Feature

comment:4 Changed 19 months ago by Stuart Auchterlonie <stuarta@…>

In b4110ae5f6a744b768711e4926439b83b201e105/mythtv:

Implement fuzzy matching of channels for EIT.

Refs #10784. First try to find the channel using the full
NetID, TransportID, ServiceID. If that fails try again using
just NetID, ServiceID.

We can extend this further using some of the other ideas in
this ticket.

comment:5 Changed 19 months ago by stuarta

  • Milestone changed from unknown to 0.27
  • Status changed from new to assigned

comment:6 Changed 16 months ago by Karl Dietz <dekarl@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 3c3dd7c5372aefe9b597f2fc0b3509a61e4f2e37/mythtv:

Handle EIT events of the active transport without looking at original_network_id or transport_id

Refs #8770 - ONID/TSID presumed missing in the OP's case
Refs #10217 - ONID/TSID did not get populated, should now work without
Fixes #10784

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.