Opened 23 months ago
Closed 21 months ago
[PATCH] libmyth: Prevent an access violation by the ALSA library
|Reported by:||Lawrence Rust <lvr@…>||Owned by:||jyavenard|
|Component:||MythTV - Audio Output||Version:||Master Head|
In audiooutputalsa.cpp, AudioOutputALSA::GetDevices? calls the ALSA API snd_device_name_hint with a card index of -1 to obtain a list of hints for all cards. Unfortunately, with libasound.so.2.0 this API can cause an access violation when the card index is -1. See http://code.google.com/p/chromium/issues/detail?id=95797
Running with valgrind shows that snd_device_name_hint makes reference to previously freed memory when called with a card index of -1.
This patch enumerates the cards using other ALSA APIs, thus avoiding the SEGV.
The access violation is often seen when starting from an empty dbase and attempting to enter the audio setup screen. The bug also applies to fixes/0.25 and 0.24.
Change History (6)
Changed 23 months ago by Lawrence Rust <lvr@…>
comment:1 Changed 23 months ago by jyavenard
comment:2 Changed 23 months ago by jyavenard
- Status changed from new to accepted
Changed 22 months ago by Lawrence Rust <lvr@…>
comment:3 Changed 22 months ago by Lawrence Rust <lvr@…>
comment:4 Changed 21 months ago by jyavenard
- Resolution set to Fixed
- Status changed from accepted to closed