Opened 7 years ago

Last modified 7 years ago

#10894 new Patch - Feature

Enable mythconfirmation dialog to pause playback

Reported by: Tobias Maier <diespambox@…> Owned by:
Priority: minor Milestone: unknown
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

First patch (Enable-mythconfirmation-dialog-to-pause-playback.patch) enhances the behavior of the MythConfirmationDialog? during playback: If a MythUserMessage? with ExtraData? set to "pauseplayback" (instead of a timeout) is received while in playback, playback is paused until the dialog is dissmissed.

The second patch (add-network-control-command-message_pause.patch) adds the network control command "message_pause" which uses the feature introduce in the first patch. I'm not really happy with the command name, but i did not want to change the syntax of "message" because i think this would break a lot of peoples scripts...

Both patches were created against the master branch.

Since i don't know what's the preferred way to submit patches here are the patches as commits on github:

Enable-mythconfirmation-dialog-to-pause-playback.patch:

https://github.com/tobser/mythtv/commit/238d243481669fc54011db7bc939268d1b6390df

add-network-control-command-message_pause.patch:

https://github.com/tobser/mythtv/commit/35b707d55bf13557fc64a1b89150318dec9acf95

Attachments (3)

Enable-mythconfirmation-dialog-to-pause-playback.patch (5.2 KB) - added by Tobias Maier <diespambox@…> 7 years ago.
add-network-control-command-message_pause.patch (3.0 KB) - added by Tobias Maier <diespambox@…> 7 years ago.
0001-fix-osd-menu-broken-in-commit-238d243481669fc54011db.patch (1.2 KB) - added by Tobias Maier <diespambox@…> 7 years ago.
fix stuff broken in enable-mythconfirmation-dialog-to-pause-playback.patch

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Tobias Maier <diespambox@…>

Changed 7 years ago by Tobias Maier <diespambox@…>

Changed 7 years ago by Tobias Maier <diespambox@…>

fix stuff broken in enable-mythconfirmation-dialog-to-pause-playback.patch

comment:1 Changed 7 years ago by Tobias Maier <diespambox@…>

sorry but i was somehow tricked by the merge... and broke the OSD menu. 0001-fix-osd-menu-broken-in-commit-238d243481669fc54011db.patch fixes the OSD menu.

https://github.com/tobser/mythtv/commit/80cdcf545ff37cb2285775f91abc540a958b70ce

I'm sorry for the mess...

Note: See TracTickets for help on using tickets.