Opened 7 years ago

Closed 6 years ago

#11057 closed Patch - Feature (Won't Fix)

Allow Custom Airplay/Airtunes display names

Reported by: Chris Whiteford <mythtv@…> Owned by: JYA
Priority: minor Milestone: unknown
Component: MythTV - Airplay Version: Master Head
Severity: medium Keywords: Airplay
Cc: Ticket locked: no

Description

Give the Airplay and ROAP servers the ability to use a custom display name pulled from the settings table in the DB.

Lets you turn Mythtv on "frontend1.mythtv" into "Living Room".

There is NO UI for setting this new identifier included in this patch.

This is my first patch submission as well. If there are any issues please let me know and I'll revise as needed.

Attachments (1)

airplaydisplayname.patch (6.2 KB) - added by Chris Whiteford <mythtv@…> 7 years ago.

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by Chris Whiteford <mythtv@…>

Attachment: airplaydisplayname.patch added

comment:1 Changed 7 years ago by Chris Whiteford <mythtv@…>

Bah. Typo. Make that...

Lets you turn "Mythtv on frontend1.mythtv" into "Living Room".

comment:2 Changed 7 years ago by sphery

This will require a settings widget (grouped with any other related settings) before it can be accepted--we don't want settings that require direct database manipulation. Creating the widget should be pretty straightforward--and make it easier for a dev to review/accept the patch--but feel free to ask on list or IRC if you have questions. Thanks.

comment:3 Changed 7 years ago by Raymond Wagner

As an alternative suggested in IRC, we just use the existing setting to control that string. Continue to use the profile name, and change the profile name to what identifying string you want that instance to appear as. The profile name defaults to the local system hostname, but can be configured within the config.xml in 0.26, or mysql.txt in 0.25 and previous.

comment:4 in reply to:  3 ; Changed 7 years ago by Chris Whiteford <mythtv@…>

Replying to wagnerrp:

As an alternative suggested in IRC, we just use the existing setting to control that string. Continue to use the profile name, and change the profile name to what identifying string you want that instance to appear as. The profile name defaults to the local system hostname, but can be configured within the config.xml in 0.26, or mysql.txt in 0.25 and previous.

I tried to find some information about the profilename/hostname details in config.xml but as of yet haven't found it (and I am still crawling thought the code).

But one question that it brings up is an example of my deployment.

I have a machine that is a slave backend (all the disk-space and processing power for 2 HDHRs) that I also use as a frontend for my home theater.

I would very much like backend settings to have a hostname of slavebackend1, frontend settings to have a host name of frontend1.mythtv (which I can't do right now - at least with my limited knowledge as to how the name is used from the config.xml/mysql.txt file), and the airplay display name to be Home Theater.

So assuming the solution you posted above in using the profile name I end up with everything being named Home Theater (from settings through to Airplay display name).

I'll work on adding a settings widget and I'll attach that patch once I have something working.

comment:5 in reply to:  4 ; Changed 7 years ago by Raymond Wagner

Replying to Chris Whiteford <mythtv@…>:

Replying to wagnerrp:

As an alternative suggested in IRC, we just use the existing setting to control that string. Continue to use the profile name, and change the profile name to what identifying string you want that instance to appear as. The profile name defaults to the local system hostname, but can be configured within the config.xml in 0.26, or mysql.txt in 0.25 and previous.

I would very much like backend settings to have a hostname of slavebackend1, frontend settings to have a host name of frontend1.mythtv (which I can't do right now - at least with my limited knowledge as to how the name is used from the config.xml/mysql.txt file), and the airplay display name to be Home Theater.

Run the two applications with different home directories, so they pick up different ~/.mythtv/config.xml files, or set the MYTHCONFDIR environmental variable so it searches a completely different path entirely, however that is really a question that belongs more on the mythtv-users mailing list, than on trac.

comment:6 in reply to:  5 Changed 7 years ago by Chris Whiteford <mythtv@…>

Replying to wagnerrp:

Replying to Chris Whiteford <mythtv@…>:

Replying to wagnerrp:

As an alternative suggested in IRC, we just use the existing setting to control that string. Continue to use the profile name, and change the profile name to what identifying string you want that instance to appear as. The profile name defaults to the local system hostname, but can be configured within the config.xml in 0.26, or mysql.txt in 0.25 and previous.

I would very much like backend settings to have a hostname of slavebackend1, frontend settings to have a host name of frontend1.mythtv (which I can't do right now - at least with my limited knowledge as to how the name is used from the config.xml/mysql.txt file), and the airplay display name to be Home Theater.

Run the two applications with different home directories, so they pick up different ~/.mythtv/config.xml files, or set the MYTHCONFDIR environmental variable so it searches a completely different path entirely, however that is really a question that belongs more on the mythtv-users mailing list, than on trac.

Fair enough.

I'll get to work on the settings UI and post it to get this ticket back on topic :-)

comment:7 Changed 7 years ago by Raymond Wagner

Component: MythTV - GeneralMythTV - RAOP
Owner: set to JYA

comment:8 Changed 6 years ago by JYA

Resolution: Won't Fix
Status: newclosed

if you want to submit a patch for an enhancement, please do so.

but don't mix a patch that reorganise the code or change function name, and add feature. keep things separate.

thank you

Note: See TracTickets for help on using tickets.