Opened 7 years ago

Closed 6 years ago

#11095 closed Patch - Bug Fix (Fixed)

Enhance videodescrip statetype to recognize more resolutions

Reported by: Yeechang Lee <ylee@…> Owned by: stuartm
Priority: minor Milestone: 0.27
Component: MythTV - User Interface Library Version: Unspecified
Severity: medium Keywords: videodescrip osd
Cc: Ticket locked: no

Description

The videodescrip statetype used in osd.xml currently identifies recordings by height, which causes letterboxed files (such as a film that is 1920x816) to not match. The attached patch uses width, not height, to match. It also returns a new, generic "HD" statetype for files that don't otherwise match as 720, 1080i, 1080p, or SD but are of greater than SD resolution, such as 4K (3840x2160) or the 1440x1080 that Dish Network and BBC use.

Attachments (3)

patch-videodescrip.diff (939 bytes) - added by Yeechang Lee <ylee@…> 7 years ago.
Patch for libs/libmythtv/mythplayer.cpp
patch-11095-2.diff (960 bytes) - added by Yeechang Lee <ylee@…> 7 years ago.
Now patches on height or width
patch-11095-3.diff (1.1 KB) - added by Yeechang Lee <ylee@…> 7 years ago.
Match more SD videos. A letterboxed 720x300 DVD should be reported as "SD" even if below 480 pixels in height

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by Yeechang Lee <ylee@…>

Attachment: patch-videodescrip.diff added

Patch for libs/libmythtv/mythplayer.cpp

comment:1 Changed 7 years ago by stuartm

The height is the more accurate measure of resolution for video, there is a reason we use height and not width. The BBC's non-square pixel 1440x1080 is rendered as 1920x1080, making it much more accurately described as 1080i/p (Full HD) than something which is rendered as 1920x816 (closer to 720).

I'm not adverse to fudging it so that both are described as Full HD, but turning it on it's head so that it breaks something like BBC HD for the sake of matching a letterboxed film is wrong.

comment:2 Changed 7 years ago by Yeechang Lee <ylee@…>

I see your point. That said, describing a 1920x816 film as "720" doesn't seem right when it has slightly more pixels than 1440x1080, which the player currently describes as "1080".

Another version is attached matching on height or width, and recordings that match on nether getting the generic "HD" statetype.

Changed 7 years ago by Yeechang Lee <ylee@…>

Attachment: patch-11095-2.diff added

Now patches on height or width

Changed 7 years ago by Yeechang Lee <ylee@…>

Attachment: patch-11095-3.diff added

Match more SD videos. A letterboxed 720x300 DVD should be reported as "SD" even if below 480 pixels in height

comment:3 Changed 6 years ago by stuartm

Milestone: unknown0.27

comment:4 Changed 6 years ago by stuartm

Resolution: Fixed
Status: newclosed

In bd6019666299dec3ea5a134b61bfa1943756d19e/mythtv:

Enhance videodescrip statetype to recognize more resolutions

Fixes #10095

Signed-off-by: Stuart Morgan <​smorgan@…>

Note: See TracTickets for help on using tickets.