Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#11104 closed Bug Report - General (fixed)

SET_BOOKMARK still expects 5 tokens (4 parameters)

Reported by: fetzer.ch@… Owned by: Raymond Wagner
Priority: minor Milestone: 0.27
Component: MythTV - General Version: Master Head
Severity: low Keywords:
Cc: Ticket locked: no

Description

In protocol version 66 (http://code.mythtv.org/trac/changeset/1508085e/mythtv) SET_BOOKMARK was changed from 2 long parameters to a int64 parameter for the bookmark.

Neverthless the command still expects 5 tokens: https://github.com/MythTV/mythtv/blob/master/mythtv/programs/mythbackend/mainserver.cpp#L722

This should be changed to 4, but I guess a new protocol version bump would be also required then. It works fine with a 0.25 backend when you add the 5th dummy parameter.

Change History (2)

comment:1 Changed 5 years ago by Raymond Wagner <rwagner@…>

Owner: set to Raymond Wagner <rwagner@…>
Resolution: fixed
Status: newclosed

In a8722faea68e8f7d2bb12f31bf78d6bc272dbdde/mythtv:

Correct sanity check on SET_BOOKMARK protocol command

The SET_BOOKMARK backend protocol command performed a sanity check to
ensure there were four arguments (plus command) sent to it, however
after 1508085e, two of the arguments denoting a 64-bit value were merged
to a single argument, and it only used three. This updates the sanity
check to match.

A brief search does not so any instance of this actually being used int
the code, so this does not merit updating the protocol version.

Fixes #11104

comment:2 Changed 5 years ago by Raymond Wagner

Milestone: unknown0.27
Owner: changed from Raymond Wagner <rwagner@…> to Raymond Wagner
Note: See TracTickets for help on using tickets.