Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#11192 closed Bug Report - General (fixed)

Menu items available in watch recordings are inconsistent

Reported by: amb@… Owned by: paulh
Priority: trivial Milestone: 0.27
Component: MythTV - General Version: 0.26-fixes
Severity: low Keywords:
Cc: Ticket locked: no

Description

When in the watch recordings screen selecting the menu for a recording gives different menus depending on the recording state. These options are inconsistent.

All recordings should allow the "Show Recording Details" option and not just "file not found"/"zero bye" file recordings because this is the only way to see the full program details if they don't fit on screen.

The "file not found"/"zero bye" recordings should have the "Recording Options" option available so that it is possible to reschedule the failed recording.

The "file not found"/"zero bye" recordings can be added to/removed from the playlist, but the playlist options themselves cannot be selected.

All of this behaviour is hard-coded in the function PlaybackBox::ShowActionPopup?() in mythtv/programs/mythfrontend/playbackbox.cpp.

Attachments (1)

playbackbox.cpp.diff (1.1 KB) - added by amb@… 6 years ago.
Patch for all this (as described in comment 2)

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 years ago by stuartm

Milestone: unknown0.27
Owner: set to stuartm
Priority: minortrivial
Status: newaccepted

1) Menu > Recording Options > Show Recording Details or just press INFO (which imho should be bound on ALL remotes)

2) I'll fix

3) Ditto

Last edited 6 years ago by stuartm (previous) (diff)

comment:2 in reply to:  1 Changed 6 years ago by amb@…

Replying to stuartm:

1) Menu > Recording Options > Show Recording Details or just press INFO (which imho should be bound on ALL remotes)

I didn't know about that keybinding.

The bug title is about inconsistency and either the menu should show the "Show Recording Details" option for all files or it should show it for no files (e.g. if there is a key binding). Currently this menu option is shown only for files that have zero bytes or no file - this is inconsistent.

comment:3 Changed 6 years ago by stuartm

It IS shown for all recordings, under the 'Recording Options' sub-menu

Changed 6 years ago by amb@…

Attachment: playbackbox.cpp.diff added

Patch for all this (as described in comment 2)

comment:4 Changed 5 years ago by Paul Harrison <pharrison@…>

Resolution: fixed
Status: acceptedclosed

In 2a7a749c82d95b7b0abdaa33697face3f823c8f6/mythtv:

Watch Recordings: make the menu items consistent for missing recordings

This makes the menu shown for recordings that are missing or zero bytes
consistent with those for normal recordings allowing those recording to
be re-scheduled etc.

Fixes #11192.

comment:5 Changed 5 years ago by paulh

Owner: changed from stuartm to paulh
Note: See TracTickets for help on using tickets.