Modify

Opened 5 years ago

Closed 3 weeks ago

#11264 closed Patch - Feature (Won't Fix)

For the ttvdb.py -N option, return all episode data that matches a episode name

Reported by: r.d.vaughan@… Owned by: wagnerrp
Priority: minor Milestone: 0.27.7
Component: MythTV - Mythmetadatalookup Version: 0.25-fixes
Severity: low Keywords: ttvdb, scripts, metadata
Cc: Ticket locked: no

Description

At this time when there are two TV episodes with identical episode names, the ttvdb.py grabber only returns metadata for the last matching episode in theTvdb.com. This can be the metadata for an episode that has not been broadcast yet.

With the attached patch, ttvdb.py now returns multiple episode's "<item>" metadata in a most recent broadcast (ascending) episode order.

To be of value, this patch requires a MythTV change which when multiple "<item>"s are returned by ttvdb.py, MythTV uses the program's "original air date" to match against the TTVDB episode's "<releasedate>". If there is no match or there is no program "original air date" then select the first "<item>"s metadata, this will duplicate what is being used today.

Note that the thetvdb.com episode "<releasedate>" is unique for an episode and is identical for all languages.

The attached patch is valid for MythTV v0.25 and higher.

Basically this patch allows MythTV recording metadata to be a little more accurate. Recently the TV series Haven and American Horror Story both had identical episode names which using Schedule Direct's "original air date" could have been properly identified. Changes to the python metadata bindings, MythWeb, Service APIs and/or the mythmetadatalookup may be require.

Attachments (1)

ttvdb_py_v025_and_higher_multiple_episodes.patch (21.2 KB) - added by wagnerrp 5 years ago.

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by wagnerrp

comment:1 Changed 5 years ago by r.d.vaughan@…

Just to be clear the statement "Recently the TV series Haven and American Horror Story both had identical episode names which using Schedule Direct's "original air date" could have been properly identified." should be stated as each TV series recently had multiple episodes with the same name Haven's "Magic Hour" season 3 episodes 7 and 8, American Horror Story's "I Am Anne Frank" season 2 episodes 4 and 5.

comment:2 Changed 5 years ago by wagnerrp

  • Milestone changed from unknown to 0.27
  • Owner changed from mdean to wagnerrp
  • Status changed from new to accepted

comment:3 Changed 5 years ago by wagnerrp

  • Milestone changed from 0.27 to 0.27.1

comment:4 Changed 3 years ago by dekarl

  • Component changed from Contributed Scripts & Apps to MythTV - Mythmetadatalookup
  • Milestone 0.27.2 deleted

According to thetvdb these story arcs that span multiple episodes are missing the part/arc number in your guide and should have been fixed in the guide instead. (Looking at the high data quality of SD that appears to be a viable option)

http://thetvdb.com/?tab=season&seriesid=158661&seasonid=491933&lid=7

Magic Hour (1)
Magic Hour (2)

http://thetvdb.com/?tab=season&seriesid=250487&seasonid=497727&lid=7

I Am Anne Frank (1)
I Am Anne Frank (2)

I hope this will all be moot soon[tm] when SD-JSON includes references to thetvdb directly.

comment:5 Changed 3 years ago by stuarta

  • Milestone set to 0.27.6

comment:6 Changed 2 years ago by dekarl

  • Milestone changed from 0.27.6 to 0.27.7

Reschedule all tickets planned for, but not solved in time for, 0.27.6 to 0.27.7.

comment:7 Changed 3 weeks ago by stuarta

  • Resolution set to Won't Fix
  • Status changed from accepted to closed

Closing any remaining open tickets for 0.27

If the issue still persists, feel free to reopen and align to a current release (v29 or master)

Add Comment

Modify Ticket

Action
as closed The owner will remain wagnerrp.
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.