Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#11265 closed Patch - Bug Fix (fixed)

Palette is not updated when DVD menu highlight changes

Reported by: peper03@… Owned by: stuartm
Priority: minor Milestone: 0.26.1
Component: MythTV - DVD Playback Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Each 'button' on a DVD menu can use a different palette selection but at the moment the first palette encountered is used for all buttons.

The effects of this can be as minor as the wrong colour being used to completely invisible highlights if the colour referenced is set to transparent in the first palette.

The attached patch ensures the palette for the current highlight is updated each time the highlight changes.

Attachments (2)

0001-Set-palette-correctly-when-DVD-menu-highlight-change.patch (1.2 KB) - added by peper03@… 17 months ago.
PaletteTest.zip (166.9 KB) - added by peper03@… 17 months ago.
Small ISO which can be used to reproduce the problem

Download all attachments as: .zip

Change History (6)

Changed 17 months ago by peper03@…

Changed 17 months ago by peper03@…

Small ISO which can be used to reproduce the problem

comment:1 Changed 17 months ago by stuartm

  • Milestone changed from unknown to 0.26.1
  • Owner set to stuartm
  • Status changed from new to accepted

comment:2 Changed 17 months ago by Richard <peper03@…>

  • Resolution set to fixed
  • Status changed from accepted to closed

In 5df1322ae0f73566766bcde0c7948292877fd443/mythtv:

Set palette correctly when DVD menu highlight changes to ensure highlights are the right colour/have the correct transparency.

Fixes #11265

Signed-off-by: Stuart Morgan <smorgan@…>

comment:3 Changed 17 months ago by Richard <peper03@…>

In bfa76a2f924af04327afcf4b04177a2fd6870f24/mythtv:

Set palette correctly when DVD menu highlight changes to ensure highlights are the right colour/have the correct transparency.

Fixes #11265

Signed-off-by: Stuart Morgan <smorgan@…>
(cherry picked from commit 5df1322ae0f73566766bcde0c7948292877fd443)

comment:4 Changed 17 months ago by Richard <peper03@…>

In 67d56643698694a6fb61e67e50ae109c127f30af/mythtv:

Set palette correctly when DVD menu highlight changes to ensure highlights are the right colour/have the correct transparency.

Fixes #11265

Signed-off-by: Stuart Morgan <smorgan@…>
(cherry picked from commit 5df1322ae0f73566766bcde0c7948292877fd443)

Conflicts:

mythtv/libs/libmythtv/DVD/dvdringbuffer.cpp

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.