Opened 7 years ago

Closed 6 years ago

#11274 closed Patch - Bug Fix (fixed)

mythpreviewgen: Allow screengrab without seek table

Reported by: managementboy@… Owned by: stuartm
Priority: minor Milestone: 0.27
Component: MythTV - Mythpreviewgen Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Stuart applied a patch from Lawrence at https://github.com/MythTV/mythtv/commit/9f992779383240c601fefdc7bd5049c2703e9959 but it is missing the last few lines of the diff. The previews only get created if hasFullPositionMap is not a requirement.

--- mythtv-0.27.0~master.20121204.c05c1e1.orig/mythtv/libs/libmythtv/mythplayer.cpp                                           
+++ mythtv-0.27.0~master.20121204.c05c1e1/mythtv/libs/libmythtv/mythplayer.cpp                                                
@@ -4329,12 +4329,8 @@ void MythPlayer::SeekForScreenGrab(uint6                                                               
         }                                                                                                                    
     }                                                                                                                        
                                                                                                                              
-    // Only do seek if we have position map                                                                                  
-    if (hasFullPositionMap)                                                                                                  
-    {                                                                                                                        
-        DiscardVideoFrame(videoOutput->GetLastDecodedFrame());                                                               
-        DoJumpToFrame(number, kInaccuracyNone);                                                                              
-    }                                                                                                                        
+    DiscardVideoFrame(videoOutput->GetLastDecodedFrame());                                                                   
+    DoJumpToFrame(number, kInaccuracyNone);                                                                                  
 }   

Change History (5)

comment:1 Changed 7 years ago by Jim Stichnoth

Owner: set to stuartm
Status: newassigned

comment:2 Changed 6 years ago by stuartm

Milestone: unknown0.27
Status: assignedaccepted

comment:3 Changed 6 years ago by stuartm

Type: Bug Report - GeneralPatch - Feature

comment:4 Changed 6 years ago by stuartm

Type: Patch - FeaturePatch - Bug Fix

comment:5 Changed 6 years ago by Stuart Morgan <smorgan@…>

Resolution: fixed
Status: acceptedclosed

In ecd5c6f12d32273790b009b47385cfc493d72b08/mythtv:

Allow screengrab without seektable. Fixes #11274

Note: See TracTickets for help on using tickets.