Opened 3 years ago
Closed 3 years ago
Last modified 2 years ago
Use the right highlight area in DVD menus when 'wide' is not the first in the list.
|Reported by:||peper03@…||Owned by:||stuartm|
|Component:||MythTV - DVD Playback||Version:||0.26-fixes|
Menu sub-pictures (highlights) are never scaled and so up to three can be supplied with each menu. These are 'wide', 'letterbox' and 'pan&scan'. 'Wide' is used when a 16:9 display is used, 'letterbox' when a 4:3 display should show a 16:9 image and 'pan&scan' when the image should be cropped to fit a 4:3 display full-screen.
Because the co-ordinates of the menu hotspots change depending on which display method is (potentially) used, these are also given for each method.
Myth already uses the 'wide' sub-picture but the libdvdnav library provides no direct way to retrieve the current highlight area for a given display method. It always returns the first set of co-ordinates found. Most DVDs seem to store the 'wide' co-ordinates first so the highlight area return by libdvdnav is usually correct. As far as I can tell, this is not a requirement. If the order is different, it can be at best ugly (e.g. part of the highlight is cropped) and at worst impossible to visibly navigate a DVD menu (e.g. the highlight is cropped completely).
The attached patch adds functionality to libdvdnav to return the highlight area for a given display method. This functionality could be placed in DVDRingBuffer if preferred as it only requires access to the PCI structure.
The required behaviour was determined (more or less) from these sources:
See also the sample 'ButtonGroup?.iso' in stuartm's sample repository.
Change History (5)
Changed 3 years ago by peper03@…
comment:1 Changed 3 years ago by Richard <peper03@…>
- Owner set to Richard <peper03@…>
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed 3 years ago by kenni
- Owner changed from Richard <peper03@…> to stuartm
comment:3 Changed 3 years ago by kenni
- Milestone changed from unknown to 0.27