Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 16 months ago

Closed 15 months ago

Last modified 15 months ago

#11296 closed Patch - Bug Fix (fixed)

Add the DCX-3200 as a supported box-type

Reported by: Tom Flair <praetor.zero@…> Owned by: danielk
Priority: minor Milestone: 0.26.1
Component: MythTV - General Version: Master Head
Severity: medium Keywords: firewire, dcx-3200
Cc: Ticket locked: no

Description

The vendor ids for the DCX-3200 variants are included under firewiredevice.cpp, but the DCX-2500 is not listed as a supported model. Because of this, I get the following error in my logs:
CoreContext? recorders/firewirechannel.cpp:68 (Open) - FireChan?(address): Model: 'DCX-3200' is not supported

I can confirm that the box does indeed work (and has for a while now) and just needs a simple addition to firewirechannel.cpp for this to work.

Attachments (1)

dcx-3200support.v2.patch (471 bytes) - added by Tom Flair <praetor.zero@…> 16 months ago.
Simple patch defining the DCX-2500 as a supported model.

Download all attachments as: .zip

Change History (6)

Changed 16 months ago by Tom Flair <praetor.zero@…>

Simple patch defining the DCX-2500 as a supported model.

comment:1 Changed 16 months ago by danielk

Tom, what version of MythTV are you using?

The patch you've attached tries to add the DCX-3200 to the list in videosource.cpp, but it is already in the list in master. In your bug report you mention the DCX-2500, but the log snippet refers to the DCX-3200...

My guess is you really want me to add the DCX-3200 to the list in FirewireDevice::IsSTBSupported().
Is that correct?

comment:2 Changed 16 months ago by Tom Flair <praetor.zero@…>

Ooops. Yeah, that's exactly what I meant. I typed that out while staring at the 2500s on my slave backend. Yes, please add the DCX-3200.

As to version, I'm running master. I pulled 43e17c509e7c420c6853dc015243c239d8f26006 on the 17th. I usually do weekly builds off of master.

comment:3 Changed 16 months ago by danielk

  • Milestone changed from unknown to 0.26.1
  • Owner set to danielk
  • Status changed from new to accepted

comment:4 Changed 15 months ago by Daniel Thor Kristjansson <danielk@…>

  • Resolution set to fixed
  • Status changed from accepted to closed

In d493cec60a5d4ccca64dd7d31871d5c2fd048390/mythtv:

Add DCX-3200 as a supported Firewire recorder STB.

Fixes #11296.

comment:5 Changed 15 months ago by Daniel Thor Kristjansson <danielk@…>

In c86a3d78953ac1e3ffa10f670c73c836cfb1235d/mythtv:

Add DCX-3200 as a supported Firewire recorder STB.

Fixes #11296.

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.