Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 15 months ago

Closed 10 months ago

Last modified 10 months ago

#11348 closed Bug Report - General (fixed)

Cannot transcode to atsc HD resolutions

Reported by: Matthew Gabeler-Lee <fastcat@…> Owned by: cpinkham
Priority: minor Milestone: 0.27
Component: MythTV - Mythtranscode Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

As a result of some bugs, and the removal of ATSC as a valid TV Format (see #4343 and #7966), transcoding with resizing to HD resolutions is broken.

There are a couple pieces to this issue.

First, the limitation of NTSC sources to SD resolutions seems to be wrong, if ATSC HD content is meant to be included in the meaning of NTSC (see recordingprofile.cpp:1128).

Just above that is an override to allow full HD resolutions when transcoding. But mythtranscode does not set the transcoding flag when loading a recording profile. This seems to be becaue the logic to identify when transcoding is active is based on the profile name starting with "Transcoders" (recordingprofile.cpp:1117). But that is normally the profile group name, not the profile name. The profile group name is not passed in.

Workaround: only use custom transcoding profiles, and name all of them "Transcoders - whatever".

That does nothing for the posibility of an analog HD source, of course.

Attachments (0)

Change History (3)

comment:1 Changed 15 months ago by wagnerrp

  • Owner set to cpinkham
  • Status changed from new to assigned

I'm assigning this to Chris, since it will likely be fixed automatically when the HLS code is expanded for use with general purpose transcoding.

comment:2 Changed 10 months ago by Chris Pinkham <cpinkham@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 2c9bc10e3af53d990445c750b56f13f8f129e300/mythtv:

Fix transcoding to high resolutions.

When the transcoder loaded the recording profile, the max width and
height fields were not being set properly so transcoding profiles
with high resolutions were instead limited to 768x576. Since these
max values are set the ImageSize? ctor, changing them after the fact
is a bit invasive. Rather than using a RecordingProfile? variable
in Transcode and trying to change the values after the fact, this patch
fixes the issue by using a RecordingProfile? pointer and creating an
instance allowing us to tell the constructor that the profile we're
going to load is a transcoder profile and the max resolution values
(and any other transcoder-specific values or limits) should be
set correctly.

Fixes #11348.

comment:3 Changed 10 months ago by cpinkham

  • Milestone changed from unknown to 0.27
  • Version changed from 0.26-fixes to Master Head

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.