Opened 18 years ago
Closed 18 years ago
Last modified 18 years ago
#1139 closed patch (fixed)
Add HD, CC, and Stereo indicators
| Reported by: | kkuphal | Owned by: | kkuphal |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.20 |
| Component: | mythtv | Version: | head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
This is my ticket for tracking the addition of HD, CC, and Stereo attributes to various places in mythfrontend.
- Add HD, CC, and Stereo attributes to ProgramInfo?
- Populate HD, CC and Stereo attributes when building ProgramInfo? on backend and via queries.
- Add HD, CC, and Stereo icons to Watch Recordings when a recording has these attributes. These should fit nicely next to the current icons.
- Add HD, CC, and Stereo icons to Program Guide
Attachments (4)
Change History (12)
Changed 18 years ago by
| Attachment: | icons.diff added |
|---|
comment:1 Changed 18 years ago by
| Type: | task → patch |
|---|---|
| Version: | → head |
Attached patch populates Stereo, HD, and CC fields in ProgramInfo? and populates them for theme designers. The MythCenter? theme (which I use) is also patched to display these icons next to the standard icon sets.
Since I don't normally use the other themes, I didn't touch them but they will also need modification to display these icons.
Also, I believe since I added these fields a protocol bump is in order so I'm not commiting this myself so soon after 0.19. When a bump is in order, this should be applied at the same time to reduce the impact.
No modifications were made to the Program Guide or other places that could potentially use these icons.
comment:2 Changed 18 years ago by
Wouldn't it be better to squish these into a bit mask? It seems silly to me to add more bytes to an already large program info, that gets frequently transmitted over the network.
Or maybe it's the embedded programmer in me. :/
comment:3 Changed 18 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:5 Changed 18 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
the, could i (respectfully) suggest that it is not fixed, but partially fixed.
comment:6 Changed 18 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
If you have additional comments, please post to -dev. This is not a a discussion forum .
comment:7 Changed 18 years ago by
(In [9029]) Add a 'transcoded' flag to the recorded table. The flag defaults to 0 and is set/unset by the JobQueue? for a running, successful, or unsuccessful transcode job. Support has also been added to the PlaybackBox? (aka the Watch Recordings Screen) for displaying a 'transcoded' icon to indicate which recordings have been transcoded. This is not present in any themes, but the support has been added.
As part of this, I cleaned up the status icon code a bit in playbackbox.cpp eliminating some repetitive code by creating a loop that checks all icons. I also added support for the new CC, HDTV, and Stereo icons to the popup help window since I was working on that area of the code.
This enhances and closes #1308. I applied the patch in #1308 then added the frontend support and reworked the status icon code while I was in there.
References #1139.
Adds HD, CC, and Stereo icons to ProgramInfo? and MythCenter? theme