Opened 11 years ago
Closed 11 years ago
Last modified 11 years ago
#11440 closed Bug Report - General (fixed)
Patch: Fix audio sync
Reported by: | Owned by: | JYA | |
---|---|---|---|
Priority: | minor | Milestone: | 0.25.4 |
Component: | MythTV - Audio Output | Version: | 0.26-fixes |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
I have many files where the A/V sync would be off by 300-400 ms. Upon closer examination, the files in question had rather large audio packets, coincidentally the same size as the A/V sync error. So I dug into the code, thinking somewhere in the A/V sync routines, it was referencing the timestamp of the beginning of the audio packet, rather than the end. As it turns out, it looks like a simple typo is to blame.
Attached is my fix, which fixes the A/V sync on all my problematic files.
Attachments (2)
Change History (9)
Changed 11 years ago by
Attachment: | audio.diff added |
---|
comment:1 Changed 11 years ago by
Changed 11 years ago by
Attachment: | badavsync.1.patch added |
---|
comment:2 Changed 11 years ago by
Ive now found a 2nd issue which has been checked with timestamp analysis in log files. Playback is now smooth again esp at higher timestretch values.
SetAudiotime? needs the original frames added not the frames obtained from preprocessing as well as scaling the number of frames suitably.
2nd patch contains the both fixes.
comment:3 Changed 11 years ago by
Status: | new → infoneeded_new |
---|
Could you provide a sample with high A/V sync issue ? thanks
comment:4 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | infoneeded_new → closed |
comment:7 Changed 11 years ago by
Milestone: | unknown → 0.25.4 |
---|
Reviewed. Yes it looks to be a typo. All frames need to be scaled by 100000 to convert to timestamps.