Opened 6 years ago

Closed 6 years ago

#11443 closed Patch - Bug Fix (fixed)

DVD menu highlight disappears almost as soon as it is shown.

Reported by: peper03@… Owned by: stuartm
Priority: major Milestone: 0.27
Component: MythTV - DVD Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

A side-effect of [3194b9f481] is that 'fps' is no longer set at the end of AvFormatDecoder::ScanStreams?. When a new subpicture stream is encountered, ScanStreams? is called but 'fps' is always set to zero even when video streams should be ignored.

The mismatch between 'fps' and the detected frame-rate is eventually detected in AvFormatDecoder::MpegPreProcessPkt?, which in turn eventually leads to the video output being re-initialised, which causes captions (i.e. subpictures) to be cleared.

The attached patch ensures that 'fps' is not touched unless video streams should be scanned.

Attachments (1)

0001-Make-sure-DVD-menu-highlight-isn-t-hidden-immediatel.patch​ (1.2 KB) - added by peper03@… 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by peper03@…

Attachment: 0001-Make-sure-DVD-menu-highlight-isn-t-hidden-immediatel.patch​ added

comment:1 Changed 6 years ago by stuartm

Owner: set to stuartm
Status: new → accepted

comment:2 Changed 6 years ago by stuartm

Milestone: unknown → 0.27

comment:3 Changed 6 years ago by Richard <peper03@…>

Resolution: → fixed
Status: accepted → closed

In dbf2878b2fed62837d6e1b9a960501a2570cdf6d/mythtv:

Make sure DVD menu highlight isn't hidden immediately due to framerate
being set to zero, which, when followed down the chain, causes a video
re-initialisation, which clears any subpicture.

Fixes #11443

Signed-off-by: Stuart Morgan <smorgan@…>

Note: See TracTickets for help on using tickets.