Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11445 closed Patch - Bug Fix (fixed)

DVD menu highlights are not always shown

Reported by: peper03@… Owned by: Richard <peper03@…>
Priority: minor Milestone: 0.27
Component: MythTV - DVD Playback Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Menu highlights for menus in the VTS domain are not always shown as the stream ID is only set if there is at least one button when the subpicture stream change notification arrives but it not possible to know how many buttons are available until a NAV packet arrives, so the stream ID is not set.

The attached patch sets of the stream ID when the first NAV packet with button information arrives. It also cleans up the code responsible for detecting a looping menu (so that the selected button is not changed when the loop restarts), which also didn't work with menus in the VTS domain.

A sample DVD image (DelayedMenu_VTS.iso) is available in stuartm's DVD repository.

Attachments (1)

0001-Fix-displaying-of-menu-highlights-when-a-menu-appear.patch​ (6.0 KB) - added by peper03@… 5 years ago.

Download all attachments as: .zip

Change History (3)

Changed 5 years ago by peper03@…

Attachment: 0001-Fix-displaying-of-menu-highlights-when-a-menu-appear.patch​ added

comment:1 Changed 5 years ago by Richard <peper03@…>

Owner: set to Richard <peper03@…>
Resolution: → fixed
Status: new → closed

In 6fce2124610e1b5e971e58248717bd3927e785ef/mythtv:

VTS title and clean up menu looping detection.

Querying the number of buttons as soon as a subpicture stream change
notification appears is generally not possible as the button
information is carried in NAV packets, which probably haven't been
read yet.

Fixes #11445

Signed-off-by: Stuart Morgan <smorgan@…>

comment:2 Changed 5 years ago by Raymond Wagner

Milestone: unknown → 0.27
Note: See TracTickets for help on using tickets.