Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11495 closed Patch - Feature (fixed)

Patch to service api (dvr endpoint) allowing editing of existing recording schedules + backports dvr endpoint changes in trunk

Reported by: dev-team@… Owned by: gigem
Priority: minor Milestone: 0.27
Component: Bindings - XML/JSON Version: Master Head
Severity: medium Keywords: services-api dvr
Cc: Ticket locked: no

Description

Patch to service api (dvr endpoint) allowing editing of existing recording schedules + backports dvr endpoint changes in trunk

Attachments (6)

mythtv-0.26-serviceapi-dvr-editschedule.patch​ (13.0 KB) - added by dev-team@… 5 years ago.
mythtv-0.27-serviceapi-dvr-editschedule.patch​ (10.5 KB) - added by dev-team@… 5 years ago.
mythtv-0.26-serviceapi-dvr-editschedule.2.patch​ (13.1 KB) - added by dev-team@… 5 years ago.
renamed Edit -> Update
mythtv-0.27-serviceapi-dvr-editschedule.2.patch​ (10.6 KB) - added by dev-team@… 5 years ago.
renamed Edit -> Update
mythtv-0.27-serviceapi-dvr-editschedule.3.patch​ (19.6 KB) - added by dev-team@… 5 years ago.
updated Add / Update method definitions for a more complete set
mythtv-0.27-serviceapi-dvr-editschedule.4.patch​ (35.6 KB) - added by anonymous 5 years ago.

Download all attachments as: .zip

Change History (10)

Changed 5 years ago by dev-team@…

Attachment: mythtv-0.26-serviceapi-dvr-editschedule.patch​ added

Changed 5 years ago by dev-team@…

Attachment: mythtv-0.27-serviceapi-dvr-editschedule.patch​ added

comment:1 Changed 5 years ago by gigem

Owner: changed from dblain to gigem
Status: new → assigned

Changed 5 years ago by dev-team@…

Attachment: mythtv-0.26-serviceapi-dvr-editschedule.2.patch​ added

renamed Edit -> Update

Changed 5 years ago by dev-team@…

Attachment: mythtv-0.27-serviceapi-dvr-editschedule.2.patch​ added

renamed Edit -> Update

Changed 5 years ago by dev-team@…

Attachment: mythtv-0.27-serviceapi-dvr-editschedule.3.patch​ added

updated Add / Update method definitions for a more complete set

Changed 5 years ago by anonymous

Attachment: mythtv-0.27-serviceapi-dvr-editschedule.4.patch​ added

comment:2 Changed 5 years ago by David Engel <dengel@…>

Resolution: → fixed
Status: assigned → closed

In 2865936d776f42759e2b41ed152126b0b264eb32/mythtv:

Rework recording rule handling in services API.

Thanks to tafy/dev-team%40tikinou.com providing the initial patch and
testing the end result.

The existing AddRecordSchedule?() and new UpdateRecordSchedule?() calls
essentially take complete, fully-specified rules and sanity check them
before saving. AddRecordSchedule?() is used to add new rules and
UpdateRecordSchedule?() is used to update existing rules.

GetRecordSchedule?() is changed to conveniently provide rules suitable
for later calls to AddRecordSchedule?() and UpdateRecordSchedule?().
When given a valid RecordId?, GetRecordSchedule?() returns that rule.
When given a Template name, GetRecordSchedule?() returns an empty rule
initialized with that template. When given a ChanId? and StartTime?,
GetRecordSchedule?() returns the rule for that program or a new one if
no rule currently exists. If the MakeOverride? parameter is true, the
returned rule for the program will converted to an override rule if
needed.

Clients should always call GetRecordSchedule?() with the appropriate
parameters before modifying the rule and then calling
AddRecordSchedule?() or UpdateRecordSchedule?(). In this way, clients
do not need to know all of the details on how to initialize rules or
update them for specific programs.

Fixes #11495

comment:3 Changed 5 years ago by gigem

Version: 0.26-fixes → Master Head

comment:4 Changed 5 years ago by Raymond Wagner

Milestone: unknown → 0.27
Note: See TracTickets for help on using tickets.