Opened 6 years ago

Closed 4 years ago

#11562 closed Patch - Bug Fix (fixed)

Patch: MythTV Status page in mythweb doesn't print "Suggested next mythfilldatabase run"

Reported by: Bill Meek <keemllib@…> Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.28
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Based on a 0.26 user's comment on the -users channel, jxself [05-28-2013 00:47:03]

The date comparison of sNext and sStart is checking different time formats. This causes the following to fail, and not print the next run:

...
if (!next.isNull() && sNext >= sStart)
{
    os << "    Suggested next mythfilldatabase run: "
            << sNext << ".<br />\r\n";
...

In this example, MythFillSuggestedRunTime? = 2013-05-29T08:57:58Z and mythfilldatabaseLastRunStart = 2013-05-28 12:34:40 (which has already been converted to localtime.)

Without the attached patch (sNext = UTC):

sNext (2013-05-29 08:57:58) >= sStart (Tue May 28, 7:34 AM) = 0

With the attached patch (sNext = Local time):

sNext (Wed May 29, 3:57 AM) >= sStart (Tue May 28, 7:34 AM) = 1

Attachments (3)

version.txt (874 bytes) - added by Bill Meek <keemllib@…> 6 years ago.
v0.27-pre2-1133-g3247383-dirty (with this patch)
suggestedstarttime.patch.v0 (824 bytes) - added by Bill Meek <keemllib@…> 6 years ago.
suggestedstarttime.patch.v1 (1.5 KB) - added by Bill Meek <keemllib@… 6 years ago.
Replaces .v0

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by Bill Meek <keemllib@…>

Attachment: version.txt added

v0.27-pre2-1133-g3247383-dirty (with this patch)

Changed 6 years ago by Bill Meek <keemllib@…>

Attachment: suggestedstarttime.patch.v0 added

Changed 6 years ago by Bill Meek <keemllib@…

Attachment: suggestedstarttime.patch.v1 added

Replaces .v0

comment:1 Changed 6 years ago by cpinkham

Owner: set to cpinkham
Status: newassigned

comment:2 Changed 5 years ago by Bill Meek <keemllib@…>

Considering WebFrontend?, please close.

comment:3 Changed 4 years ago by Stuart Auchterlonie

Milestone: unknown0.28

comment:4 Changed 4 years ago by Stuart Auchterlonie

Owner: changed from cpinkham to Stuart Auchterlonie
Status: assignedaccepted

comment:5 Changed 4 years ago by Stuart Auchterlonie <stuarta@…>

Resolution: fixed
Status: acceptedclosed

In 4e8e6615c97cb29c9931caaf9481f926afb59e18/mythtv:

Fixes #11562 Properly compare next and start times for MFDB run

Note: See TracTickets for help on using tickets.