Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#11580 closed Patch - Bug Fix (fixed)

Patch to eliminate (logically) dead code in decoderbase.cpp - fixes coverity 700308

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: dekarl
Priority: minor Milestone: 0.27
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Static analysis (coverity) detected logically dead code in decoderbase.cpp, where selTrack would never be less than zero. Commit ea554c9 assigned selTrack the value 0 in the block previously, make this check dead.

Fixes coverity 700308

Patch: https://github.com/garybuhrmaster/mythtv/commit/82c88731988568902ec56a27c0877d068bb98d18

Attachments (0)

Change History (3)

comment:1 Changed 11 months ago by stuartm

  • Milestone changed from unknown to 0.27
  • Owner set to stichnot
  • Status changed from new to assigned

comment:2 Changed 11 months ago by Gary Buhrmaster <gary.buhrmaster@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In bae00573e4882b5f7a3f9480279434008690f23c/mythtv:

Eliminate (logically) dead code

After commit [ea554c9c] selTrack will never have the value -1
(it is assigned 0 in the block previous if it had that value).
Remove the (redundant) checks.

Fixes coverity 700308.
Fixes #11580

comment:3 Changed 11 months ago by dekarl

  • Owner changed from stichnot to dekarl
  • Type changed from Bug Report - General to Patch - Bug Fix

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.