Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11580 closed Patch - Bug Fix (fixed)

Patch to eliminate (logically) dead code in decoderbase.cpp - fixes coverity 700308

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: dekarl
Priority: minor Milestone: 0.27
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Static analysis (coverity) detected logically dead code in decoderbase.cpp, where selTrack would never be less than zero. Commit ea554c9 assigned selTrack the value 0 in the block previously, make this check dead.

Fixes coverity 700308

Patch: https://github.com/garybuhrmaster/mythtv/commit/82c88731988568902ec56a27c0877d068bb98d18

Change History (3)

comment:1 Changed 5 years ago by stuartm

Milestone: unknown0.27
Owner: set to Jim Stichnoth
Status: newassigned

comment:2 Changed 5 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: assignedclosed

In bae00573e4882b5f7a3f9480279434008690f23c/mythtv:

Eliminate (logically) dead code

After commit [ea554c9c] selTrack will never have the value -1
(it is assigned 0 in the block previous if it had that value).
Remove the (redundant) checks.

Fixes coverity 700308.
Fixes #11580

comment:3 Changed 5 years ago by dekarl

Owner: changed from Jim Stichnoth to dekarl
Type: Bug Report - GeneralPatch - Bug Fix
Note: See TracTickets for help on using tickets.