Opened 8 years ago

Closed 8 years ago

#11581 closed Patch - Bug Fix (fixed)

Patch to remove redundant (logically useless) check in decoderbase.cpp

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Jim Stichnoth
Priority: minor Milestone: 0.27
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no


Static analysis (IEAEYEBALL), during the analysis of coverity 700308 which resulted in ticket 11580, noticed that the check in a number of conditionals for numStreams not being zero was redundant, since the function checked for that value near the beginning, and returned false if it was zero. Eliminate the extra checks.


Change History (2)

comment:1 Changed 8 years ago by stuartm

Milestone: unknown0.27
Owner: set to Jim Stichnoth
Status: newassigned

comment:2 Changed 8 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: assignedclosed

In 431669005cd87124a199da013b59bf29a9bc58e9/mythtv:

Remove redundant check

The codes check for numStream being zero previously,
and return from the function if it is zero.

Fixes #11581

Note: See TracTickets for help on using tickets.