Modify

Opened 2 years ago

Closed 2 years ago

#11581 closed Patch - Bug Fix (fixed)

Patch to remove redundant (logically useless) check in decoderbase.cpp

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: stichnot
Priority: minor Milestone: 0.27
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Static analysis (IEAEYEBALL), during the analysis of coverity 700308 which resulted in ticket 11580, noticed that the check in a number of conditionals for numStreams not being zero was redundant, since the function checked for that value near the beginning, and returned false if it was zero. Eliminate the extra checks.

Patch: https://github.com/garybuhrmaster/mythtv/commit/18b4ce0e1107257748060bca754a9dd69878e8fe

Attachments (0)

Change History (2)

comment:1 Changed 2 years ago by stuartm

  • Milestone changed from unknown to 0.27
  • Owner set to stichnot
  • Status changed from new to assigned

comment:2 Changed 2 years ago by Gary Buhrmaster <gary.buhrmaster@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 431669005cd87124a199da013b59bf29a9bc58e9/mythtv:

Remove redundant check

The codes check for numStream being zero previously,
and return from the function if it is zero.

Fixes #11581

Add Comment

Modify Ticket

Action
as closed The owner will remain stichnot.
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.