Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 11 months ago

Closed 10 months ago

Last modified 10 months ago

#11586 closed Patch - Bug Fix (fixed)

Patch to check success of socket creation in iptvstreamhandler.cpp - fixes coverity 746816

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Gary Buhrmaster <gary.buhrmaster@…>
Priority: minor Milestone: 0.27
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

While unlikely, the socket creation could fail, returning an error rather than a file descriptor. Log it, and continue.

Note that coverity reported "Improper use of negative value" later in the code where calling setsockopt with the fd could be calling with a negative value. This patch checks at socket creation time.

Fixes coverity 746816

Patch: https://github.com/garybuhrmaster/mythtv/commit/db44509884e10110b81332f53d7c9e56af7b2f61.patch

Attachments (0)

Change History (2)

comment:1 Changed 10 months ago by Gary Buhrmaster <gary.buhrmaster@…>

  • Owner set to Gary Buhrmaster <gary.buhrmaster@…>
  • Resolution set to fixed
  • Status changed from new to closed

In fa1a1780e02c594bf795a9ad2eadd965afd7fecd/mythtv:

Patch to check success of the socket creation

While unlikely, the socket creation could fail,
returning an error rather than a file descriptor.
Log it, and continue.

Fixes coverity 746816
(cherry picked from commit db44509884e10110b81332f53d7c9e56af7b2f61)

Fixes #11586

Signed-off-by: Stuart Morgan <smorgan@…>

comment:2 Changed 10 months ago by paulh

  • Milestone changed from unknown to 0.27

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.