Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11594 closed Patch - Bug Fix (fixed)

Patch to address potential integer overflow in dtvchannel.cpp - fixes coverity 700586

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Gary Buhrmaster <gary.buhrmaster@…>
Priority: minor Milestone: 0.27
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Support higher tuning frequencies :-)

Static analysis (coverity) detected that some of the math computing frequencies was performed in 32 bit arithmetic, even though the result was 64 bits. This could result in an integer overflow. Use the Qt long long type to move to 64 bit calculations.

Fixes coverity 700586

github direct link: https://github.com/garybuhrmaster/mythtv/commit/788496de9cafe49db76ea67ce4f17d6e7f5f03e7

(or, if you prefer the other format)

github git-am formatted link: https://github.com/garybuhrmaster/mythtv/commit/788496de9cafe49db76ea67ce4f17d6e7f5f03e7.patch

Change History (2)

comment:1 Changed 5 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Owner: set to Gary Buhrmaster <gary.buhrmaster@…>
Resolution: fixed
Status: newclosed

In d395df6ad8c4f6580fb0c3047022b61860942455/mythtv:

Support higher tuning frequencies

Static analysis (coverity) detected that some of the
math computing frequencies was performed in 32 bit
arithmetic, even though the result was 64 bits. This
could result in an integer overflow. Use the Qt
long long type to move to 64 bit calculations.

Fixes coverity 700586
Fixes #11594

Signed-off-by: Daniel Kristjansson <danielk@…>

comment:2 Changed 5 years ago by paulh

Milestone: unknown0.27
Note: See TracTickets for help on using tickets.