Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#11594 closed Patch - Bug Fix (fixed)

Patch to address potential integer overflow in dtvchannel.cpp - fixes coverity 700586

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Gary Buhrmaster <gary.buhrmaster@…>
Priority: minor Milestone: 0.27
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Support higher tuning frequencies :-)

Static analysis (coverity) detected that some of the math computing frequencies was performed in 32 bit arithmetic, even though the result was 64 bits. This could result in an integer overflow. Use the Qt long long type to move to 64 bit calculations.

Fixes coverity 700586

github direct link: https://github.com/garybuhrmaster/mythtv/commit/788496de9cafe49db76ea67ce4f17d6e7f5f03e7

(or, if you prefer the other format)

github git-am formatted link: https://github.com/garybuhrmaster/mythtv/commit/788496de9cafe49db76ea67ce4f17d6e7f5f03e7.patch

Attachments (0)

Change History (2)

comment:1 Changed 10 months ago by Gary Buhrmaster <gary.buhrmaster@…>

  • Owner set to Gary Buhrmaster <gary.buhrmaster@…>
  • Resolution set to fixed
  • Status changed from new to closed

In d395df6ad8c4f6580fb0c3047022b61860942455/mythtv:

Support higher tuning frequencies

Static analysis (coverity) detected that some of the
math computing frequencies was performed in 32 bit
arithmetic, even though the result was 64 bits. This
could result in an integer overflow. Use the Qt
long long type to move to 64 bit calculations.

Fixes coverity 700586
Fixes #11594

Signed-off-by: Daniel Kristjansson <danielk@…>

comment:2 Changed 10 months ago by paulh

  • Milestone changed from unknown to 0.27

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.