Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#11595 closed Patch - Bug Fix (fixed)

Patch to address potential integer overflow in freesurround.cpp - fixes coverity 700584

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: jyavenard
Priority: minor Milestone: 0.27
Component: MythTV - Audio Output Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Static analysis (coverity) detected that some of the math in the routine getLatency was performed in 32 bit arithmetic, even though the result was 64 bits. This could result in an integer overflow. Cast to 64 bits

Note that a quick check (perhaps wrong) showed that this method was never called, so this is probably an irrelevant identified defect.

Fixes coverity 700584

github direct link: https://github.com/garybuhrmaster/mythtv/commit/499584ef7e20f97c738427fffc2657a56f1617ab

or, if you prefer,

Patch in git-am format: https://github.com/garybuhrmaster/mythtv/commit/499584ef7e20f97c738427fffc2657a56f1617ab.patch

Attachments (0)

Change History (2)

comment:1 Changed 10 months ago by Gary Buhrmaster <gary.buhrmaster@…>

  • Resolution set to fixed
  • Status changed from new to closed

In a08ece53bc706ef1ab2afed712a5c71f1f093f64/mythtv:

Patch to address potential integer overflow

Static analysis (coverity) detected that some of the math
in the routine getLatency was performed in 32 bit arithmetic,
even though the result was 64 bits. This could result in an
(theoretical) integer overflow. Cast to 64 bits to fix the
defect.

Note that a quick check (perhaps wrong) showed that this
method was never called, so this is probably an irrelevant
identified defect.

Fixes coverity 700584
(cherry picked from commit 499584ef7e20f97c738427fffc2657a56f1617ab)

Fixes #11595

Signed-off-by: Stuart Morgan <smorgan@…>

comment:2 Changed 10 months ago by paulh

  • Milestone changed from unknown to 0.27

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.