Opened 7 years ago

Closed 7 years ago

#11613 closed Patch - Bug Fix (Fixed)

Patch to initialize (and properly copy) the aes key/iv values in httplivestreambuffer.cpp - fixes coverity 1023902

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by:
Priority: minor Milestone: 0.27
Component: MythTV - HTTP Streaming Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Static analysis indicated that the key/iv variables were not initialized. Strictly speaking, they do not have to be, since they are protected by a boolean flag variable. But to make coverity happy, initialize them (note that the init value of zero is not any more correct or wrong than a random uninitialized value for the cryptographic operations).

In addition, the assignment operator did not copy the iv (even though it copied the flag variable). This looks like a real bug.

Fixes coverty 1023902

github ref: https://github.com/garybuhrmaster/mythtv/commit/c084f6d6a2e2338744b86baa03bce3816caea9db

githum git-am ref: https://github.com/garybuhrmaster/mythtv/commit/c084f6d6a2e2338744b86baa03bce3816caea9db.patch

Change History (2)

comment:1 Changed 7 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Please close this ticket. Patch applied by jya in commits 7153ea8271adcd09cbffb635d7b5d3ff6cd79bbb and 473130bbfded09be2ea4811e7eb2203fa885da75

comment:2 Changed 7 years ago by Raymond Wagner

Milestone: unknown0.27
Resolution: Fixed
Status: newclosed
Note: See TracTickets for help on using tickets.