Opened 7 years ago

Closed 7 years ago

#11635 closed Patch - Bug Fix (Fixed)

(Specultive) patch to initialize m_readbuf in mythsystemwindows.cpp

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: danielk
Priority: minor Milestone: 0.27
Component: MythTV - MythSystem Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In commit e2ec92f129f32c42442cf5c46ef92da0e7c90d20 m_readbuf was initialized in mythsystemunix.cpp based on cppcheck warning. Do the same in mythsystemwindows.cpp for consistency (and because if static analysis was run on the windows source, it would likely report the same issue).

This is a speculative patch. My attempts at compiling in Windows have not been successful. This patch looks correct, and is consistent with its sibling for mythsystemunix.cpp. Nevertheless, it could be bad. If the windows buildbot manages to be resurrected, and this patch is applied and causes difficulties I am willing to assist in resolution.

github ref: https://github.com/garybuhrmaster/mythtv/commit/5c6be52e39dd853543c6796ef9bf602b68c640cf

github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/5c6be52e39dd853543c6796ef9bf602b68c640cf.patch

Change History (4)

comment:1 Changed 7 years ago by danielk

Owner: set to danielk
Status: newaccepted

I should be able to test this..

comment:2 Changed 7 years ago by paulh

Milestone: unknown0.27

comment:3 Changed 7 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Looks like this has been (independently) fixed in 414bc61b6effb1c0054639cde42b2b21c12dcd57 that was just committed.

Please close this ticket to avoid duplicate work.

Gary

comment:4 Changed 7 years ago by Nicolas Riendeau

Resolution: Fixed
Status: acceptedclosed

Closed at submitter's request.

Note: See TracTickets for help on using tickets.