Opened 6 years ago

Closed 5 years ago

#11636 closed Patch - Bug Fix (fixed)

(Speculative) patch to initialize member variables in ctor - sibling to ticket #11629

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: danielk
Priority: minor Milestone: 0.27.2
Component: MythTV - MythSystem Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In ticket #11629 there is attached a proposed patch 4dc18c79d3d3b1885b251318f404473c5e691c2a which initialized member variables in mythsystemunix.cpp to fix a coverity issue. Do the same in mythsystemwindows.cpp for consistency (and because if static analysis was run on the windows source, it would likely report the same issue).

This is a speculative patch. My attempts at compiling in Windows have not been successful. This patch looks correct, and is consistent with its sibling for mythsystemunix.cpp. Nevertheless, it could be bad. If the windows buildbot manages to be resurrected, and this patch is applied and causes difficulties I am willing to assist in resolution.

github ref: https://github.com/garybuhrmaster/mythtv/commit/77bed7bce0e492fc6b04f16b6c971191b679b88a

github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/77bed7bce0e492fc6b04f16b6c971191b679b88a.patch

Change History (4)

comment:1 Changed 6 years ago by danielk

Owner: set to danielk
Status: newaccepted

I should be able to test this..

comment:2 Changed 6 years ago by paulh

Milestone: unknown0.27

comment:3 Changed 6 years ago by stuartm

Milestone: 0.270.27.1

comment:4 Changed 5 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: acceptedclosed

In be9cb47b1dfcddf31f3027b03938ad6af3fd1007/mythtv:

Initialize member variables in ctor

In patch 4dc18c79d3d3b1885b251318f404473c5e691c2a
member variables were initialized in mythsystemunix.cpp
to fix a coverity issue. Do the same in
mythsystemwindows.cpp for consistency (and because
if static analysis was run on the windows source,
it would likely report the same issue).

Signed-off-by: Gary Buhrmaster <gary.buhrmaster@…>
Signed-off-by: Stuart Morgan <smorgan@…>

Fixes #11636

Note: See TracTickets for help on using tickets.