Opened 8 years ago
Closed 8 years ago
Last modified 8 years ago
#11638 closed Patch - Feature (Won't Fix)
Improve duplicate check algorithm
| Reported by: | Owned by: | gigem | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.26.1 |
| Component: | MythTV - Scheduling | Version: | 0.26-fixes |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Every morning show on the german station RTL2 provides the EIT-subtitle in the subtitle field while the high-definition broadcast "RTL2 HD" puts the subtitle in front of the description and leaves the subtitle field blank. That way I get scheduler conflict since MythTV doees not recognize those two showings being the same show. I added a patch to improve the agorithm.
Attachments (4)
Change History (8)
Changed 8 years ago by
| Attachment: | duplicate_algorithm_20130702.diff added |
|---|
Changed 8 years ago by
| Attachment: | duplicate_algorithm_20130709.diff added |
|---|
comment:1 Changed 8 years ago by
| Owner: | set to gigem |
|---|---|
| Status: | new → assigned |
comment:2 Changed 8 years ago by
I'm wondering why the existing fixup doesn't move the episode title from the description to the subtitle field. See EITFixUp::FixRTL in eitfixup.cpp Can you post a dump of one of each events (dvbsnoop including hexdump would be great) so we can test that? Maybe its as simple as adding another service to eithelper.cpp.
comment:3 Changed 8 years ago by
| Resolution: | → Won't Fix |
|---|---|
| Status: | assigned → closed |
Thanks for the patch. I won't accept it, however, since the chance of creating false positives is just too high. When in doubt, we usually try to err on the side that results in more programs being recorded, even if they are duplicates. It's easier to delete a duplicate recording after the fact than it is re-record a missed program that might not be shown again for a very long time, if ever.
Anyway, the developer who does a lot of the XMLTV and EIT work would like to know why the existing EIT fixups don't handle your problem. Please post on the mythtv-dev mailing list or drop by the #mythtv IRC channel. Ask for Karl Deitz in email or dekarl on IRC.
comment:4 Changed 8 years ago by
Thanks for your response! The reason why the EIT fixup don't jump in is because the transport_id für all HD-transponders is missing. Only the SD transponder is covered!
I believe the following code in static void init_fixup(...) should do the trick!
fix[ 1089LL << 32 | 1 << 16] = // DVB-S fix[ 1057LL << 32 | 1 << 16] = // DVB-S RTL Group HD Transponder fix[ 1041LL << 32 | 1 << 16] = // DVB-S RTL Group HD Austria Transponder
Have not tested it!
Updated patch