Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#11659 closed Patch - Bug Fix (fixed)

Patch to initialize m_glDeleteProgram in ResetProcs - fixes coverity 700928 and 700929

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Gary Buhrmaster <gary.buhrmaster@…>
Priority: minor Milestone: 0.27
Component: MythTV - User Interface Library Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Static analysis detected that the m_glDeleteProgram member variables was not being initialized in the ctor. The ctor invokes ResetVars? and ResetProcs?. This particular member variable was missing in ResetProcs?.

Fixes coverity 700928 700929

github ref: ​https://github.com/garybuhrmaster/mythtv/commit/f4258355035e972422c150d670e1b6d1d263a08d
github git-am ref: ​https://github.com/garybuhrmaster/mythtv/commit/f4258355035e972422c150d670e1b6d1d263a08d.patch

Attachments (0)

Change History (2)

comment:1 Changed 9 months ago by Gary Buhrmaster <gary.buhrmaster@…>

  • Owner set to Gary Buhrmaster <gary.buhrmaster@…>
  • Resolution set to fixed
  • Status changed from new to closed

In 99a2a1725bdfa637d27fb1dde1d58d49090954b5/mythtv:

Initialize m_glDeleteProgram in ResetProcs?

The ctors of MythRenderOpenGL2 invoke ResetProcs?
to initialize the members. Add m_glDeleteProgram
to the initialization.

Fixes coverity 700928 and 700929

Fixes #11659.

Signed-off-by: Paul Harrison <pharrison@…>

comment:2 Changed 9 months ago by paulh

  • Milestone changed from unknown to 0.27

Add Comment

Modify Ticket

Action
as closed .
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.