Modify
Warning Please read the Ticket HowTo before creating or commenting on a ticket. Failure to do so may cause your ticket to be rejected or result in a slower response.

Opened 9 months ago

Last modified 4 months ago

#11678 new Bug Report - General

Video metadata downloads the least popular fanart from tmdb

Reported by: anonymous@… Owned by: wagnerrp
Priority: minor Milestone: 0.26.1
Component: MythTV - General Version: Unspecified
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This is seen with current master. It has been an issue for well over a year as well. I have seen at least one other person mention this on the users list and it was dismissed as a false report.

When a query to tmdb returns multiple rows for fanart, the last one is downloaded and used. This is the lowest rated from tmdb and should not be the one used.

Simply changing tmdp3.py to use m.images.insert(0,{...}) rather than m.images.append({...}) (reverses the sort) for fanart results in the proper image being used. I assume, however, that the fix should actually be in myth's code. Coverart also uses the append method and the first item is downloaded in that case.

On another note, if you reset all metadata for a video, it does not delete the existing fanart. When you then retrieve details, it also does not overwrite the existing image. Unless you manually delete the image, you cannot replace it with an updated one. To refresh an image, one has to both delete the fanart file and clear their themecache entry which is cumbersome.

Attachments (0)

Change History (4)

comment:1 Changed 9 months ago by wagnerrp

  • Milestone changed from unknown to 0.26.1
  • Owner set to wagnerrp
  • Status changed from new to accepted

comment:2 Changed 9 months ago by Raymond Wagner <rwagner@…>

  • Resolution set to fixed
  • Status changed from accepted to closed

In da8ac305c3dbe955459a6a12e646b81109552836/mythtv:

Fix metadata fanart selection.

When artwork is processed from metadata grabber results, the artwork is
put into a QMultiMap, indexed based off the type. When pulling values
back out of a QMultiMap, they are in reverse order from how they were
inserted. Since the grabber is assumed to place the highest rated
artwork at the top of the response list, it must be pulled back out of
the bottom of the QMultiMap.

Commit c3d64c80 made this change for all artwork types by fanart. Fanart
had special handling, to allow it to select different artwork for each
season of a television show. However, the logic used to select the
artwork resulted in being indexed from the beginning of the list, rather
than indexed from the back of the list, thus pulling the lowest rated
artwork rather than the highest.

Fixes #11678

comment:3 Changed 9 months ago by Raymond Wagner <rwagner@…>

In ce8f07005d607d1b6578e1085c796d0eafe490ce/mythtv:

Fix metadata fanart selection.

When artwork is processed from metadata grabber results, the artwork is
put into a QMultiMap, indexed based off the type. When pulling values
back out of a QMultiMap, they are in reverse order from how they were
inserted. Since the grabber is assumed to place the highest rated
artwork at the top of the response list, it must be pulled back out of
the bottom of the QMultiMap.

Commit c3d64c80 made this change for all artwork types by fanart. Fanart
had special handling, to allow it to select different artwork for each
season of a television show. However, the logic used to select the
artwork resulted in being indexed from the beginning of the list, rather
than indexed from the back of the list, thus pulling the lowest rated
artwork rather than the highest.

Fixes #11678
(cherry picked from commit da8ac305c3dbe955459a6a12e646b81109552836)

comment:4 Changed 4 months ago by wagnerrp

  • Resolution fixed deleted
  • Status changed from closed to new

There are reports of this issue still existing. I'm re-opening this so I don't forget it when I have a chance to look into it again.

Add Comment

Modify Ticket

Action
as new .
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.