Opened 14 years ago

Closed 14 years ago

#117 closed defect (fixed)

Native LIRC support of modifiers (alt, ctrl, etc) does not work

Reported by: ron.garrison@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version:
Severity: medium Keywords: alt, ctrl, modifier, lirc
Cc: mcarland @… Ticket locked: no

Description

The modifier code passed into QKeyEvent in MythDialogs?.cpp is incorrect. On May 30th 2005, Michael Carland provided the following patch to the myth-dev mailing list. It has not been incorporated into the CVS, however. I have tested the patch on my system and do not see any issues with it. Is this the mechanism to attempt to get this included?

Original post by Michael Carland http://mythtv.org/pipermail/mythtv-dev/2005-May/036729.html

Index: libs/libmyth/mythdialogs.cpp
===================================================================
RCS file: /var/lib/mythcvs/mythtv/libs/libmyth/mythdialogs.cpp,v
retrieving revision 1.115
diff -u -r1.115 mythdialogs.cpp
--- libs/libmyth/mythdialogs.cpp	28 May 2005 03:57:54 -0000	1.115
+++ libs/libmyth/mythdialogs.cpp	30 May 2005 23:08:14 -0000
@@ -767,6 +767,11 @@
                 text = QString(c);
             }
 
+            mod = ((mod & Qt::CTRL) ? Qt::ControlButton : 0) |
+                  ((mod & Qt::META) ? Qt::MetaButton : 0) |
+                  ((mod & Qt::ALT) ? Qt::AltButton : 0) |
+                  ((mod & Qt::SHIFT) ? Qt::ShiftButton : 0);
+
             QKeyEvent key(lke->isKeyDown() ? QEvent::KeyPress :
                           QEvent::KeyRelease, k, ascii, mod, text);

Change History (1)

comment:1 Changed 14 years ago by Isaac Richards

Resolution: fixed
Status: newclosed

(In [6863]) Patch from Michael Carland to allow modifier keys to work with native lirc.

Closes #117.

Note: See TracTickets for help on using tickets.