Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#11767 closed Bug Report - General (fixed)

Keybindings for subtitle zoom adjust are backwards

Reported by: Yeechang Lee <ylee@…> Owned by: Jim Stichnoth
Priority: minor Milestone: 0.27
Component: MythTV - Video/OSD Rendering Version: 0.26-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When adjusting subtitle zoom during playback, UP currently decreases the zoom factor and DOWN increases it. This is opposite from the way the bindings work when adjusting timestretch (UP increases timestretch factor and DOWN decreases it). Given that we are dealing with numerals, UP should increase and DOWN decrease.

Change History (3)

comment:1 Changed 6 years ago by Jim Stichnoth

Milestone: unknown0.27
Owner: set to Jim Stichnoth
Status: newaccepted

Out of the following similar dialogs - Subtitle Zoom, Subtitle Delay, Adjust Timestretch, Adjust Audio Sync - only Timestretch currently works in the consistent way between Left/Right? and Up/Down?.

comment:2 Changed 6 years ago by Jim Stichnoth <jstichnoth@…>

Resolution: fixed
Status: acceptedclosed

In deac123d039e71536f9193db514e68e2fbef4a8d/mythtv:

Make up/down adjustment directions consistent with left/right.

Fixes #11767. "Adjust Subtitle Zoom" and "Adjust Subtitle Delay"
dialogs are changed so that UP increases the value and DOWN decreases
the value.

comment:3 Changed 6 years ago by Jim Stichnoth <jstichnoth@…>

In 16c58a5a96858cb5cd0275f439ecd7fd8c2d78ee/mythtv:

Make up/down adjustment directions consistent with left/right.

This time, with the "Adjust Audio Sync" dialog, to be consistent with
"Adjust Timestretch", "Adjust Subtitle Zoom", and "Adjust Subtitle
Delay". Refs #11767

Note: See TracTickets for help on using tickets.