Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#11807 closed Patch - Bug Fix (fixed)

Patch to correct string append issue in dvbdescriptors.cpp

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: stuartm
Priority: minor Milestone: 0.27
Component: MythTV - DVB Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Clang issued a warning message: "warning: adding 'ProgramInfo::CategoryType?' to a string does not append to the string".

Patch converts the integer explicitly for the concatenation.

github ref: https://github.com/garybuhrmaster/mythtv/commit/9d88c2b2ee7084d63e2700cf6361b6b944152581

gitgub git-am ref: https://github.com/garybuhrmaster/mythtv/commit/9d88c2b2ee7084d63e2700cf6361b6b944152581.patch

Change History (3)

comment:1 Changed 6 years ago by stuartm

Milestone: unknown0.27
Owner: changed from danielk to stuartm
Status: newaccepted

comment:2 Changed 6 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: acceptedclosed

In 2a2566d3a68afb791e4a4017522a3939422e355a/mythtv:

Patch for clang detected string-plus-int issue

Clang produced a warning message:
"warning: adding 'ProgramInfo::CategoryType?'
to a string does not append to the string".
Convert the integer explicitly for the
concatenation.

Fixes #11807

Signed-off-by: Stuart Morgan <smorgan@…>

comment:3 Changed 6 years ago by Stuart Morgan <smorgan@…>

In d6ef003489128e9d076ae7bbab83450100dccc7c/mythtv:

Proper fix for #11807, use myth_category_type_to_string instead of converting the enum value to an integer for use in a string.

Refs #11807

Note: See TracTickets for help on using tickets.