Opened 6 years ago

Closed 6 years ago

#11835 closed Bug Report - General (fixed)

0.27 is failing to build on powerpc

Reported by: superm1@… Owned by: Stuart Auchterlonie
Priority: minor Milestone: 0.27
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In trying to get 0.27 into Ubuntu, I noticed that the powerpc build is not passing.

ccache g++ -c -pipe -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DPIC -maltivec -DNDEBUG -fomit-frame-pointer -fPIC -mabi=altivec -pthread -g -Wall -Wpointer-arith -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS -fvisibility-inlines-hidden -Wmissing-declarations -Wno-switch -Woverloaded-virtual -funit-at-a-time -fvisibility=hidden -D_REENTRANT -fPIC -Dusing_libcec -D_GNU_SOURCE -DMYTH_API -DUSING_OSS -DUSING_PULSE -DUSING_PULSEOUTPUT -Dlinux -DUSING_ALSA -DQT_SCRIPT_LIB -DQT_SQL_LIB -DQT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED -I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui -I/usr/include/qt4/QtXml -I/usr/include/qt4/QtSql -I/usr/include/qt4/QtScript -I/usr/include/qt4 -I/usr/include/qt4/QtDBus -I/usr -I/usr/include/libxml2 -I../../external/qjson/include -I../../external/libsamplerate -I../libmythsoundtouch -I../libmythfreesurround -I../libmythbase -I../.. -I.. -I. -I../libmythupnp -I../libmythui -I../../external/FFmpeg -I. -o audioconvert.o audio/audioconvert.cpp
audio/audiooutpututil.cpp: In static member function 'static char* AudioOutputUtil::GeneratePinkFrames(char*, int, int, int, int)':
audio/audiooutpututil.cpp:219:52: error: 'bswap_16' was not declared in this scope
                     *samp16++ = LE_SHORT(ires >> 16);
                                                    ^
audio/audiooutpututil.cpp:221:46: error: 'bswap_32' was not declared in this scope
                     *samp32++ = LE_INT(ires);
                                              ^
make[4]: *** [audiooutpututil.o] Error 1

Full log: https://launchpadlibrarian.net/149571692/buildlog_ubuntu-saucy-powerpc.mythtv_2%3A0.27.0%2Bfixes.20130907.ac841f0-0ubuntu1_FAILEDTOBUILD.txt.gz

It was passing on 0.26 previously, so something most likely with the move to bswap.h is causing a failure.

Attachments (1)

0001-Re-order-the-includes-in-audiooutpututil.cpp-to-fix-.patch (1008 bytes) - added by superm1@… 6 years ago.
Patch to fix problem

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by superm1@…

Patch to fix problem

comment:1 Changed 6 years ago by superm1@…

I set up a qemu environment to play with this failure and came to the conclusion that the toolchain isn't happy with the order of includes being wrong. Fixing the include order allows the compilation to proceed happily past this failure.

comment:2 Changed 6 years ago by Stuart Auchterlonie

Milestone: unknown0.27
Owner: set to Stuart Auchterlonie
Status: newassigned
Version: UnspecifiedMaster Head

comment:3 Changed 6 years ago by Mario Limonciello <superm1@…>

In 83fddb8ee18639465c2ba80324372ea427d88565/mythtv:

Refs #11835 Re-order the includes in audiooutpututil.cpp to fix a FTBFS on PPC.

HAVE_BYTESWAP_H is defined in mythconfig.h, however that's not included
until after bswap.h has already been included.

Signed-off-by: Stuart Auchterlonie <stuarta@…>

comment:4 Changed 6 years ago by Mario Limonciello <superm1@…>

Resolution: fixed
Status: assignedclosed

In 7a7aff2f191e9dca95a48b46265617c196b16f78/mythtv:

Fixes #11835 Re-order the includes in audiooutpututil.cpp to fix a FTBFS on PPC.

HAVE_BYTESWAP_H is defined in mythconfig.h, however that's not included
until after bswap.h has already been included.

Signed-off-by: Stuart Auchterlonie <stuarta@…>

Note: See TracTickets for help on using tickets.