Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#11845 closed Patch - Feature (fixed)

g++ C++11 standards compliance feature patch for videoout_nullvdpau.cpp and videoout_vdpau.cpp

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Gary Buhrmaster <gary.buhrmaster@…>
Priority: minor Milestone: 0.28
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Feature patch for g++ C++11 standards compliance

When compiling with g++ the compilation generates a set of warnings in the vdpau sources of the form 'warning: narrowing conversion of ...pitches... from ‘int’ to ‘uint32_t {aka unsigned int}’ inside { } [-Wnarrowing]'.

This patch explicitly casts to the appropriate type to eliminate the warnings.

Since MythTV does not currently specify use of the new C++ standards, and at this time these are only g++ warnings, this patch is really just cosmetic at this time, but may useful be at some future date (when gcc defaults to enforcing C++11 standards?)

github ref: https://github.com/garybuhrmaster/mythtv/commit/9f7f7e155cd0d88cb5a24143f3e59dd4bd57a4b5

github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/9f7f7e155cd0d88cb5a24143f3e59dd4bd57a4b5.patch

Change History (2)

comment:1 Changed 7 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Owner: set to Gary Buhrmaster <gary.buhrmaster@…>
Resolution: fixed
Status: newclosed

In 08c01ca3f415002f4decb2b0029a9afecbfc4703/mythtv:

Explicit casts for C++11 standards compliance

Fixes #11845

comment:2 Changed 7 years ago by Raymond Wagner

Milestone: unknown0.28
Note: See TracTickets for help on using tickets.