Opened 6 years ago

Closed 3 years ago

Last modified 3 years ago

#11871 closed Patch - Feature (fixed)

Qt5 porting

Reported by: danielk Owned by: Karl Egly
Priority: minor Milestone: 0.28
Component: Qt5 issues Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description


Attachments (1)

qt5-phase2.patch (11.4 KB) - added by danielk 6 years ago.
Get rid of deprecated calls in mythtv proper.

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by danielk

Attachment: qt5-phase2.patch added

Get rid of deprecated calls in mythtv proper.

comment:1 Changed 6 years ago by danielk

The qt5-phase2 patch allows MythTV proper to compile without -DQT_DISABLE_DEPRECATED_BEFORE The plugins still do not compile. This code is not tested or reviewed.

comment:2 Changed 6 years ago by danielk

Owner: set to dblain
Status: newassigned

comment:3 Changed 4 years ago by Gary Buhrmaster <gary.buhrmaster@…>

See ticket #12355 and #12067 for possible overlaps and replacements (sorry about the additional review work).

comment:4 Changed 4 years ago by Stuart Auchterlonie

Component: MythTV - GeneralQt5 issues
Milestone: unknown0.28

comment:5 Changed 3 years ago by Karl Egly

Milestone: 0.280.29
Owner: changed from dblain to Karl Egly
Status: assignedaccepted

I can take a look after the release.

comment:6 Changed 3 years ago by Gary Buhrmaster <gary.buhrmaster@…>

I *think* with the application of (most of) 12355 and 12067 that the remaining part is to remove the DEPRECATED_BEFORE parts (the last patch in the group from 12355 which I think was not applied as it had lots of warnings about applying last, etc.).

comment:7 Changed 3 years ago by Karl Dietz <dekarl@…>

Resolution: fixed
Status: acceptedclosed

In a774469fc7b4a6bef7b124f3dbce8672f0bfe60f/mythtv:

disable QT compatibility with stuff that was deprecated in QT 5.0 or earlier

This resets the compatibility to the default in QT5.
Set it to 5.2 after the release of 0.28 (we still use stuff that was
deprecated by QT5.2)

See http://doc.qt.io/qt-5/qtglobal.html#QT_DISABLE_DEPRECATED_BEFORE

Fixes #11871

comment:8 Changed 3 years ago by Karl Egly

Milestone: 0.290.28

Thanks for looking into it Gary, looks like you're right. So in it goes.

Note: See TracTickets for help on using tickets.