Opened 5 years ago

Closed 5 years ago

#11966 closed Patch - Bug Fix (Fixed)

Patch -- libc++ v libstdc++

Reported by: Craig Treleaven <ctreleaven@…> Owned by:
Priority: minor Milestone: unknown
Component: MythTV - General Version: 0.27-fixes
Severity: medium Keywords: clang libc++ libstdc++
Cc: Ticket locked: no

Description

Clang, in Apple's XCode 5, was recently updated to use libc++ instead of libstdc++. libc++ is slightly more strict and detected issues with three files; patch attached.

I am not a C/C++ developer, however. ( I am especially unsure of the change to mythpainter.cpp.) Nonetheless, I'm submitting this patch as I think someone more experienced should be able to figure out the correct approach without difficulty.

Attachments (4)

patch-various_c++_v_stdc++.diff (1.4 KB) - added by Craig Treleaven <ctreleaven@…> 5 years ago.
patch-various_c++_v_stdc++_v2.diff (827 bytes) - added by Jonatan Lindblad 5 years ago.
27 build fail onMavericks 2013Nov28_01.txt (736.0 KB) - added by Craig Treleaven <ctreleaven@…> 5 years ago.
mythpainter.cpp error, see line 4962
27 build fail onMavericks mythgesture.cpp.txt (140.1 KB) - added by Craig Treleaven <ctreleaven@…> 5 years ago.
mythgesture.cpp error, see line 1638

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by Craig Treleaven <ctreleaven@…>

comment:1 Changed 5 years ago by Jonatan Lindblad

Status: newinfoneeded_new

We need to see the actual compilation/linking errors, especially for mythuisimpletext.cpp since it doesn't even use std::abs directly.

I'll add a slightly different patch for the other two files.

Changed 5 years ago by Jonatan Lindblad

Changed 5 years ago by Craig Treleaven <ctreleaven@…>

mythpainter.cpp error, see line 4962

comment:2 in reply to:  1 Changed 5 years ago by Craig Treleaven <ctreleaven@…>

Sorry, apparently I didn't save the logs from the mythgesture.cpp and mythuisimpletext.cpp.

Changed 5 years ago by Craig Treleaven <ctreleaven@…>

mythgesture.cpp error, see line 1638

comment:3 Changed 5 years ago by Craig Treleaven <ctreleaven@…>

I've recreated the error in mythgesture.cpp and attached a log.

Can't seem to replicate the failure in mythuisimpletext.cpp!?! Strange.

comment:4 Changed 5 years ago by Craig Treleaven <ctreleaven@…>

comment:5 Changed 5 years ago by Karl Egly

Resolution: Fixed
Status: infoneeded_newclosed

closing as fixed at reporters request.

Note: See TracTickets for help on using tickets.