Opened 6 years ago

Closed 2 years ago

Last modified 20 months ago

#12029 closed Patch - Bug Fix (fixed)

Forced Subtitles (MKV) can stay onscreen indefinitely

Reported by: hamelg <hamelg@…> Owned by: Peter Bennett
Priority: minor Milestone: 0.28.2
Component: MythTV - Captions Version: 0.27-fixes
Severity: medium Keywords: forced subtitle mkv
Cc: Ticket locked: no

Description

Hello,

When regular subtitle is disabled and forced subtitle enabled (default setup), forced subtitle in mkv file stays onscreen indefinitely until it is 'cleared' by a new subtitle.

You'll find a test case here : http://gilles.hamel.free.fr/test.mkv

You can extract the srt from the mkv file with the ffmpeg utility : ffmepg -i test.mkv -vn -an -codec:s:0.2 srt sub.srt

I've attached a fix, but I am not sure if it could break anything else.

Attachments (1)

my.patch (627 bytes) - added by hamelg <hamelg@…> 6 years ago.
Patch proposed to fix the issue

Download all attachments as: .zip

Change History (17)

Changed 6 years ago by hamelg <hamelg@…>

Attachment: my.patch added

Patch proposed to fix the issue

comment:1 Changed 6 years ago by angela.schmid@…

My observation is, with forced subtitle enabled and regular subtitle disabled setup (like yours), that forced subtitles stay onscreen, when it is the only subtitle stream. When there is another subtitle stream available (does not need to be selected) forced subtitles are displayed correct.

The patch fixed the problem.

comment:2 Changed 6 years ago by hamelg <hamelg@…>

Yes, your observation is correct, but whatever the number of subtitle stream available.

comment:3 Changed 6 years ago by JYA

Milestone: 0.27.1
Resolution: Fixed
Status: newclosed

comment:4 Changed 6 years ago by JYA

Milestone: 0.27.10.27.2
Resolution: Fixed
Status: closednew

comment:5 Changed 5 years ago by Jim Stichnoth

Component: MythTV - Video/OSD RenderingMythTV - Captions
Milestone: 0.27.20.27.4
Owner: set to Jim Stichnoth
Status: newaccepted

comment:6 Changed 4 years ago by Stuart Auchterlonie

Milestone: 0.27.40.27.6

comment:7 Changed 4 years ago by angela.schmid@…

Any chance this patch makes it for 0.28?

comment:8 Changed 4 years ago by Karl Egly

Milestone: 0.27.60.27.7

Reschedule all tickets planned for, but not solved in time for, 0.27.6 to 0.27.7.

comment:9 Changed 2 years ago by kallelix@…

This is a very annoying bug. Only one line of code, please commit it to the fixes branch!

comment:10 Changed 2 years ago by steve@…

Added myself as cc.

comment:11 Changed 2 years ago by Peter Bennett

Owner: changed from Jim Stichnoth to Peter Bennett
Status: acceptedassigned

comment:12 Changed 2 years ago by Peter Bennett

Milestone: 0.27.70.28.2

I looked at the code change and tested it with a number of different recordings and videos as well as a DVD. All looks good.

comment:13 Changed 2 years ago by hamelg <hamelg@…>

Resolution: fixed
Status: assignedclosed

In e65ec0af55662833d8c2fb1606d36265c707bce7/mythtv:

Fixes #12029 Forced Subtitles (MKV) can stay onscreen indefinitely

Signed-off-by: Peter Bennett <pbennett@…>

comment:14 Changed 2 years ago by hamelg <hamelg@…>

In 6b326d2a74cd1c7a16447a3a05e38a35d158d514/mythtv:

Fixes #12029 Forced Subtitles (MKV) can stay onscreen indefinitely

Signed-off-by: Peter Bennett <pbennett@…>
(cherry picked from commit e65ec0af55662833d8c2fb1606d36265c707bce7)

comment:15 Changed 2 years ago by hamelg <hamelg@…>

In 36fe0ce319a87e49a77d39e1c006267bd8ff3893/mythtv:

Fixes #12029 Forced Subtitles (MKV) can stay onscreen indefinitely

Signed-off-by: Peter Bennett <pbennett@…>
(cherry picked from commit e65ec0af55662833d8c2fb1606d36265c707bce7)

comment:16 Changed 20 months ago by Peter Bennett

Owner: changed from Peter Bennett to Peter Bennett
Note: See TracTickets for help on using tickets.