Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#12063 closed Patch - Bug Fix (fixed)

MythMusic: Does not release audio decoder when music paused and tv playback wanted

Reported by: angela.schmid@… Owned by: angelaschmid <angela.schmid@…>
Priority: minor Milestone: 0.27.1
Component: Plugin - MythMusic Version: 0.27-fixes
Severity: medium Keywords: mythmusic playback audio decoder
Cc: Ticket locked: no

Description

When "continue play music" is active and within the MiniPlayer? pause is called, a tv/video playback can not open the audio device.

In MusicPlayer::StopPlayback? the check m_isPlaying is false, therefor not stopping the decoder.

Fix: Instead of checking m_isPlaying, use m_output the check for an existing decoder.

Attachments (1)

0001-MythMusic-Release-audio-decoder-when-music-paused-an.patch (1.1 KB) - added by angela.schmid@… 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by angela.schmid@…

comment:1 Changed 6 years ago by angelaschmid <angela.schmid@…>

Owner: set to angelaschmid <angela.schmid@…>
Resolution: fixed
Status: newclosed

In 2a5f3c8ca5d750415b8227ff2f74c3bf2cd5119d/mythtv:

MythMusic: Release audio decoder when music paused and tv playback wanted.

When "continue play music" is active and within the MiniPlayer? pause is
called, a tv/video playback can not open the audio device.

In MusicPlayer::StopPlayback? the check m_isPlaying is false, therefor not
stopping the decoder.

Fix: Instead of checking m_isPlaying, use m_output the check for an existing decoder.

#Fixes #12063.

Signed-off-by: Paul Harrison <pharrison@…>

comment:2 Changed 6 years ago by angelaschmid <angela.schmid@…>

In e11fc266d91e5350d617e3f10fdbe9cea8a739ec/mythtv:

MythMusic: Release audio decoder when music paused and tv playback wanted.

When "continue play music" is active and within the MiniPlayer? pause is
called, a tv/video playback can not open the audio device.

In MusicPlayer::StopPlayback? the check m_isPlaying is false, therefor not
stopping the decoder.

Fix: Instead of checking m_isPlaying, use m_output the check for an existing decoder.

#Fixes #12063.

Signed-off-by: Paul Harrison <pharrison@…>
(cherry picked from commit 2a5f3c8ca5d750415b8227ff2f74c3bf2cd5119d)

comment:3 Changed 6 years ago by paulh

Milestone: unknown0.27.1
Note: See TracTickets for help on using tickets.