Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#12066 closed Patch - Feature (fixed)

Feature patch for MythDownloadManager and QNetworkRequest reload support

Reported by: Gary Buhrmaster <gary.buhrmaster@…> Owned by: Gary Buhrmaster <gary.buhrmaster@…>
Priority: minor Milestone: 0.28
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

This patch has been split into multiple parts so that it can be more easily reviewed. However, only the entire set of patches being applied have been (lightly) tested.

Patch 0: Extend the ability to request a reload when download and queueDownload are called with a QNetworkRequest which specifies a reload.

Patch 1: Extend the ability to force a reload when post and queuePost are called with a QNetworkRequest. While posts are not normally cached, the RFCs allow post caching in some cases. Allow a QNetworkRequest to request the reload.

Patch 2: Insure a reload request actually requests a full reload by setting the AlwaysNetwork? attribute for CacheLoadControlAttribute?

Patch0 github ref: https://github.com/garybuhrmaster/mythtv/commit/14c5fc7f049b026b1da1de3598f994de05022dcf Patch0 github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/14c5fc7f049b026b1da1de3598f994de05022dcf.patch

Patch1 github ref: https://github.com/garybuhrmaster/mythtv/commit/dd3f93dfbf095d5530af1485c99678c503debb2d Patch1 github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/dd3f93dfbf095d5530af1485c99678c503debb2d.patch

Patch2 github ref: https://github.com/garybuhrmaster/mythtv/commit/7e1c86e1f67033b9e34a217c5f438db49c104e07 Patch2 github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/7e1c86e1f67033b9e34a217c5f438db49c104e07.patch

Change History (4)

comment:1 Changed 4 years ago by Gary Buhrmaster <gary.buhrmaster@…>

In aa701292d1ca28ea5d091b5b9ef4d9011de0e7ee/mythtv:

Extend reload support to download with QNetworkRequest

If the QNetworkRequest has a CacheLoadControlAttribute?
of AlwaysNetwork?, set the reload flag for a download
and queueDownload request.

Refs #12066

Signed-off-by: David Engel <dengel@…>

comment:2 Changed 4 years ago by Gary Buhrmaster <gary.buhrmaster@…>

In 8599d2e133eca08e8f7e1b0b07f4911ea2bc428a/mythtv:

Extend reload support to post with QNetworkRequest

If the QNetworkRequest has a CacheLoadControlAttribute?
of AlwaysNetwork?, set the reload flag for a post
and queuePost request. While posts are usually not
cached, the RFCs allow it in specific cases. This
allows the caller to request no cache processing.

Refs #12066

Signed-off-by: David Engel <dengel@…>

comment:3 Changed 4 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Owner: set to Gary Buhrmaster <gary.buhrmaster@…>
Resolution: fixed
Status: newclosed

In db3e6eed1c2731f3e6df2d263bb20a987a94ccd9/mythtv:

Request AlwaysNetwork? if m_reload is set for the request

If m_reload is true, request that Qt actually performs
similiarly to a browser reload (bypass and reload any
cache).

Fixes #12066

Signed-off-by: David Engel <dengel@…>

comment:4 Changed 4 years ago by gigem

Milestone: unknown0.28
Note: See TracTickets for help on using tickets.