Opened 10 years ago
Closed 9 years ago
Last modified 8 years ago
#12070 closed Patch - Feature (fixed)
Qt5 feature patch to resolve signed vs unsigned comparision warning for KeyboardModifier type change
Reported by: | Owned by: | ||
---|---|---|---|
Priority: | minor | Milestone: | 0.28 |
Component: | MythTV - General | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Qt5 has been released, and some distros are starting to provide it as an alternative to Qt4, although I would not expect Qt5 to be the default for quite some time. Regardless, one of the changes in Qt5 is changing the type of KeyboardModifier? from int to uint. This patch uses the correct type for the variable kLIRCInvalidKeyCombo in order to avoid a signed vs unsigned comparison warning at compile time, and as it is surrounded by a version check should be safe for any supported Qt version, and prepares MythTV for the inevitable Qt5 default on some distro at some future date (probably a few years from now) with no additional compilation warnings.
github ref: https://github.com/garybuhrmaster/mythtv/commit/6dd27d779ec31f8807c2256de26c06981b8aec4b github git-am ref: https://github.com/garybuhrmaster/mythtv/commit/6dd27d779ec31f8807c2256de26c06981b8aec4b.patch
In 28849639fe48fce4e9d2f1c4c0be8c09c3de6f0c/mythtv: