Memory leak in LoggingItem::setThreadName()

[faginbagin <mythtv@…>]

This inline method is called thousands of times, mostly via MPoolThread::run's calls to loggingRegisterThread, so the old value of m_threadName needs to be freed before a new value is set.

[Karl Egly]

After a quick look at the patch and file I'm wondering if the various setters that use strdup shouldn't all be doing the same.

[faginbagin <mythtv@…>]

This setter is the only one that popped up in the valgrind run that prompted me to test and then offer this patch, but that doesn't mean similar changes shouldn't be made to the other setters. I was also wondering if the project has any rules of thumb regarding the size and frequency of use of inline methods. IOW, should this setter (and maybe others) be moved to logging.cpp?

[Stuart Auchterlonie]

Replying to dekarl:

After a quick look at the patch and file I'm wondering if the various setters that use strdup shouldn't all be doing the same.

Yes i think they should!

[Jean-Yves Avenard <jyavenard@…>]

In c8b359dfec03574bbfb30e2ea7ed0584d34de94d/mythtv:

Tidy up code in logging

There was no leak there. Each functions are only called once as a LoggingItem? isn’t a reusable item

Fixes #12131

[Jean-Yves Avenard <jyavenard@…>]

In b15009783583edc5c663d09ebb2a7baeeeab2c96/mythtv:

Fix leak in logger

setThreadName can be called twice, obfuscating the previously allocated string

Fixes #12131

[Jean-Yves Avenard <jyavenard@…>]

In 881284c2f52f5138f2385a0686f38e8b7b14c0c9/mythtv:

Fix leak in logger

setThreadName can be called twice, obfuscating the previously allocated string

Fixes #12131

(cherry picked from commit b15009783583edc5c663d09ebb2a7baeeeab2c96)