Opened 6 years ago

Closed 6 years ago

#12140 closed Patch - Bug Fix (Fixed)

Random segfaults when using VAAPI playback

Reported by: Cédric Schieli <cschieli@…> Owned by: JYA
Priority: blocker Milestone: 0.27.1
Component: MythTV - Video Playback Version: 0.27-fixes
Severity: high Keywords: vaapi crash
Cc: Ticket locked: no

Description

The VAAPI playback is crippled with random segfaults occurring either after some time of playing or at the very first frame. This is due to VideoOutput::CropToDisplay? being applied on the fake frame buffers (VAAPI doesn't give direct access to the decoded frame buffer), ending up in heap space corruption. It was introduced in commit 0a4e3e423d6604252aeb31f849085a00f9f4b2e9 to fix #11358.

The simple attached patch fixes this.

Attachments (1)

don-t-try-to-crop-vaapi-frames.patch (882 bytes) - added by Cédric Schieli <cschieli@…> 6 years ago.

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by Cédric Schieli <cschieli@…>

comment:1 Changed 6 years ago by stuartm

Priority: minorblocker
Severity: mediumhigh

comment:2 Changed 6 years ago by Cédric Schieli <cschieli@…>

comment:3 Changed 6 years ago by Stuart Auchterlonie

Milestone: unknown0.27.1
Owner: set to Stuart Auchterlonie
Status: newassigned

comment:4 Changed 6 years ago by JYA

Owner: changed from Stuart Auchterlonie to JYA
Status: assignedaccepted

comment:5 Changed 6 years ago by Stuart Auchterlonie

In 3b621f5c4fd194aefe1c15bad78807ce85a13853/mythtv:

(The changeset message doesn't reference this ticket)

Damn typo's....

comment:6 Changed 6 years ago by JYA

Resolution: Fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.