Opened 10 years ago
Closed 10 years ago
Last modified 8 years ago
#12144 closed Patch - Feature (fixed)
Save volume only on TV Player exit (optimize DB usage)
Reported by: | Owned by: | Roger Siddons | |
---|---|---|---|
Priority: | minor | Milestone: | 0.28 |
Component: | MythTV - Audio Output | Version: | 0.27-fixes |
Severity: | low | Keywords: | mysql volume save |
Cc: | Ticket locked: | no |
Description
Saving the volume to the DB on each volume change is unnecessary. To optimize DB usage, the patch saves the volume only on exit of the TV Player (TV::PrepareToExitPlayer?).
There was also a small bug: On each volume change in the TV Player the volume is saved twice when software volume is configured:
In libs/libmyth/audio/volumebase.cpp VolumeBase::SetCurrentVolume?
- Calls UpdateVolume?, which calls SetSWVolume, when software volume is configured it saves
- the save in SetCurrentVolume? itself
Attachments (1)
Change History (7)
Changed 10 years ago by
Attachment: | 0001-Save-volume-only-on-TV-Player-exit.patch added |
---|
comment:1 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 Changed 10 years ago by
Milestone: | unknown → 0.28 |
---|
comment:6 Changed 8 years ago by
Owner: | changed from JYA to Roger Siddons |
---|
Note: See
TracTickets for help on using
tickets.
In 85baf66840dbf728af732f1d346ffe63fbe3ab41/mythtv: