Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12149 closed Bug Report - General (fixed)

Wrong Artwork retrieved for TV Shows

Reported by: skd5aner@… Owned by: JYA
Priority: critical Milestone: 0.27.4
Component: MythTV - General Version: 0.27-fixes
Severity: high Keywords:
Cc: Ticket locked: no

Description

This has been a problem reported several times on the -users mailing list and on IRC, but I couldn't find a ticket for it. For some reason, some TV shows retrieve the correct inetref id from TheTVDB, but the actually use that ID to retrieve artwork (and other metadata?) from TMDB.

A few examples: Sportscenter

artwork returned

60 Minutes

artwork returned

... and those are the relatively calm ones. However, people have reported very pornographic results being returned because of this issue. Here's just one thread: http://www.gossamer-threads.com/lists/mythtv/users/554595?search_string=artwork;#554595 and there were more recent discussions in IRC. This bug has existed for many years, and can causes a lot of issues when family members are navigating the watch recordings screen and see something X rated.

Change History (10)

comment:1 Changed 5 years ago by Raymond Wagner

Owner: set to Raymond Wagner
Status: newaccepted

comment:2 Changed 5 years ago by Karl Egly

see also #11890 and #12103

comment:3 Changed 5 years ago by JYA

Owner: changed from Raymond Wagner to JYA
Status: acceptedassigned

comment:4 Changed 5 years ago by Raymond Wagner <rwagner@…>

Resolution: fixed
Status: assignedclosed

In e82754a7041d3988a8361535460d12a47742c65b/mythtv:

Store grabber used along with inetref to ensure correct reuse.

This stores the name of the grabber that returned an inetref, prepended
to the beginning of the inetref, separate by a colon (:). This is then
used to ensure that same grabber, or one that understands its indexing,
is called any time that inetref is used. This resolves an issue where an
inetref from the Television grabber would subsequently be used to pull
data through the Movie grabber, resulting in incorrect information.

This adds a caching mechanism for the grabbers, such that the available
grabbers do not need to be rescanned each time an inetref is to be used.
This cache is expired after 60 seconds, or any time the user enters the
metadata grabber selection screen.

Fixes #12149

comment:5 Changed 5 years ago by Raymond Wagner <rwagner@…>

In ed9152a8438675b505e21b7eaab41446c8111cae/mythtv:

Specify supported previous grabbers in tmdb3.py

This specifies that tmdb3.py is able to accept the inetref indexing used
by past tmdb.py and tmdb.pl. The metadata library will then use tmdb3.py
for any existing content tagged with "tmdb.py:xxxx" or "tmdb.pl:xxxx".

Those grabbers were deprecated before the inetref tagging was added, and
so will never be used in practice, but are added for example of how to
use the mechanism.

Refs #12149

comment:6 Changed 5 years ago by JYA

Milestone: 0.280.27.4

comment:7 Changed 5 years ago by Raymond Wagner <rwagner@…>

In 1489019374fdeda953548d5d4920ecda85c91288/mythtv:

Store grabber used along with inetref to ensure correct reuse.

This stores the name of the grabber that returned an inetref, prepended
to the beginning of the inetref, separate by a colon (:). This is then
used to ensure that same grabber, or one that understands its indexing,
is called any time that inetref is used. This resolves an issue where an
inetref from the Television grabber would subsequently be used to pull
data through the Movie grabber, resulting in incorrect information.

This adds a caching mechanism for the grabbers, such that the available
grabbers do not need to be rescanned each time an inetref is to be used.
This cache is expired after 60 seconds, or any time the user enters the
metadata grabber selection screen.

Fixes #12149

(cherry picked from commit e82754a7041d3988a8361535460d12a47742c65b)

Conflicts:

mythtv/libs/libmythbase/mythversion.h
mythtv/libs/libmythmetadata/libmythmetadata.pro

comment:8 Changed 5 years ago by skd5aner@…

Please re-open... I'm still getting movie artwork loaded for TV shows after updating to latest 0.27-fixes (v0.27.3-159-g2d4a7c9)

Thanks!

comment:9 Changed 5 years ago by JYA

log or it doesn't happen...

And have you updated your existing rules?

the fix only applies to new rules / search.

not existing ones

comment:10 Changed 5 years ago by skd5aner@…

They are existing rules. My DB is 11 years old, and as such I have hundreds of rules, and I'd prefer not to have to go back and fix them individually. Can a fix for existing rules not be put in to place?

Still want me to produce a log? It's certainly happening and my wife wasn't happy when one of my recordings decided to randomly download some inappropriate artwork when it hasn't done so for months.

Note: See TracTickets for help on using tickets.