Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#12155 closed Bug Report - General (fixed)

Do not allow subtitile to be set for manual recordings

Reported by: billstei@… Owned by: gigem
Priority: minor Milestone: 0.27.2
Component: Plugin - MythWeb Version: 0.27-fixes
Severity: low Keywords: scheduler subtitle
Cc: Ticket locked: no

Description (last modified by gigem)

[Note the following original report was done with mythweb. Specifying the subtitle for manual recordings is not supported in the backend and mythweb should not allow it.]

When setting a manual recording the manually specified Subtitle is replaced incorrectly by the Startdate and Starttime and (re)placed into the "program" table. This occurs on line #3313 of scheduler.cpp in the Scheduler::UpdateManuals?() method with the following code:

query.bindValue(":SUBTITLE", startdt.toLocalTime());

I recommend that the query of the "record" table on line #3222 of scheduler.cpp include "subtitle" along with an additional line ~3236:

QString subtitle = query.value(THE_VALUE_AFTER_TITLE).toString();

A simple test for the bug can be done by setting the Recording Started System Event to the following:

logger "The Subtitle is: %SUBTITLE%"

and then checking /var/log/syslog for the correct subtitle.

Change History (9)

comment:1 Changed 6 years ago by gigem

Status: newinfoneeded_new

Specifying a subtitle for manual recordings is not supported and should not be allowed. How are you doing so? With mythweb? If so, it's a bug in mythweb for allowing it in the first place.

comment:2 Changed 6 years ago by billstei@…

Yes, mythweb.

comment:3 Changed 6 years ago by gigem

Component: MythTV - SchedulingPlugin - MythWeb
Description: modified (diff)
Owner: changed from gigem to Rob Smith
Severity: mediumlow
Status: infoneeded_newnew
Summary: Manual Recordings lose SubtitleDo not allow subtitile to be set for manual recordings

Thanks for following up.

comment:4 Changed 6 years ago by gigem

Owner: changed from Rob Smith to gigem
Status: newaccepted

comment:5 Changed 6 years ago by billstei@…

Assuming that the Subtitle entry is removed from the mythweb Manual Recording Schedule UI, does the same not-available policy apply to the "description" field ? I see in the "record" table it is set to "Manually scheduled", but in the "program" table this is not copied and is blank. It would be nice to have at least one field available for manual comments (and via mythweb), which are passed to, in this case, %DESCRIPTION% as a System Event parameter to System Event handlers.

comment:6 Changed 6 years ago by gigem

Yes, the same applies to the description field. It's another case where the mythweb developer over committed without knowing the underlying backend support. I'm sorry but I don't see a big enough need to let the user specify a subtitle or description in addition to the title. Manual recordings are expected to be a very seldom used, last resort when the guide data is not and cannot be correct. If you do intend to keep a manual recording long term for some reason and want better meta data, I believe there is already a way to edit that after the fact.

comment:7 Changed 6 years ago by sphery

Yes, in Watch Recordings, highlight the recording and choose MENU|Recording Options|Change Recording Metadata, and then edit the title, subtitle, and/or description as desired.

comment:8 Changed 6 years ago by David Engel <david@…>

Resolution: fixed
Status: acceptedclosed

In 64c2d2606832e5350e38c0441cde3d024ef9b4bf/mythweb:

Don't allow the subtitle to be edited on manual recordings.

Also, don't set the description and category.

Fixes #12155

comment:9 Changed 6 years ago by gigem

Milestone: unknown0.27.2
Note: See TracTickets for help on using tickets.