Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#12180 closed Patch - Feature (fixed)

Call Show Channel Search in Lists and Guide

Reported by: angela.schmid@… Owned by: gigem
Priority: minor Milestone: 0.28
Component: MythTV - General Version: 0.27.1
Severity: medium Keywords: channel search epg
Cc: Ticket locked: no

Description

I miss the possibility to jump to a channel program list from the EPG guide and other lists in mythfrontend.

The Guide in most themes is horizontal and scrolling can be tedious, so this patch offers a call to the channel list (Channel Search), which will be normally vertical, showing more information on the screen, with much easier scrolling for a specific channel.

This patch contains: Add "Show Channel Search" key/menu to Guide Grid, Program Finder, Upcoming Recordings, and all Program Search Lists. It takes the current Program and shows the Channel Search at the specific channel and program.

The code for ProgLister? does not have code for allowEPG, player and embedVideo to track embedding in the player, like

ProgFinder::ProgFinder(MythScreenStack *parentStack, bool allowEPG,
                       TV *player, bool embedVideo)

and

ProgFinder::~ProgFinder()
...
    if (m_player && m_allowEPG)
    {
        QString message = QString("PROGFINDER_EXITING");
        qApp->postEvent(m_player, new MythEvent(message));
    }

But ProgLister? is called from GuideGrid? and ProgFinder? when in player modus, so they will take care of screen resizing after exiting ProgLister?. The patch works fine, beware I don't use resizing. Is there anything else I should take care of?

Attachments (1)

0001-Add-Show-Channel-Search-in-several-Lists.patch (14.1 KB) - added by angela.schmid@… 5 years ago.

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by angela.schmid@…

comment:1 Changed 5 years ago by gigem

Owner: set to gigem
Status: newassigned

comment:2 Changed 5 years ago by David Engel <dengel@…>

Resolution: fixed
Status: assignedclosed

In 500f83656770a9d629b7ee93998fe17e3c9d97e2/mythtv:

Allow Channel Search to be called from additional places.

This is on a patch from Angela Schmid, but modified to use the
existing ProgLister? constructor and conform to other recent changes to
ScheduledCommon?.

Fixes #12180

comment:3 Changed 5 years ago by angela.schmid@…

Hello David, Thanks for evaluating my patch. I noticed that I uploaded a reverted patch, sorry for that.

I created a new constructor to provide a ProgramInfo? structure. The caller sets the actual program and the ProgLister? will set the current position to this program. Especially when you are couple of days further in the GuideGrid? jumping to the exact program in the ProgList? saves you from scrolling/searching this particular program. Without this functionality this patch is not that useful, and I would stay in the GuideGrid? and scroll there, although it is not practical.

Adding the ProgramInfo? to the constructor and decide on its value besides a provided chanid could also be an option.

I hope you will investigate my patch once more, and have a look into the additional code to position the ProgLister? at the provided program.

comment:4 Changed 5 years ago by gigem

Angela, thanks for this and your many other patches. Yes, it was obvious your patch was reversed. I was already planning the other ScheduledCommon? changes and knwe I wasn't going to use your patch directly anyway so it wasn't a big deal. I added code to initially select the current item in a separate commit. I didn't want a new constructor because I wanted that functionality to be generic enough that it could eventually be used with other ProgLister? modes if needed.

comment:5 Changed 5 years ago by paulh

Milestone: unknown0.28
Note: See TracTickets for help on using tickets.